Skip to content

calling_sync_routing_table is race-y #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheBlueMatt opened this issue Nov 10, 2022 · 2 comments
Open

calling_sync_routing_table is race-y #1847

TheBlueMatt opened this issue Nov 10, 2022 · 2 comments

Comments

@TheBlueMatt
Copy link
Collaborator

CI got

failures:

---- routing::gossip::tests::calling_sync_routing_table stdout ----
thread 'routing::gossip::tests::calling_sync_routing_table' panicked at 'assertion failed: (msg.first_timestamp as u64) >= expected_timestamp - 60 * 60 * 24 * 7 * 2', lightning/src/routing/gossip.rs:2807:21


failures:
    routing::gossip::tests::calling_sync_routing_table

test result: FAILED. 540 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
@TheBlueMatt
Copy link
Collaborator Author

Doesn't seem common so slipping

@TheBlueMatt TheBlueMatt removed this from the 0.0.116 milestone Apr 28, 2023
@TheBlueMatt
Copy link
Collaborator Author

Still happening, eg on windows in CI:

---- routing::gossip::tests::calling_sync_routing_table stdout ----
thread 'routing::gossip::tests::calling_sync_routing_table' panicked at 'assertion failed: (msg.first_timestamp as u64) >= expected_timestamp - 60 * 60 * 24 * 7 * 2', lightning\src\routing\gossip.rs:2923:21
stack backtrace:
   0: std::panicking::begin_panic<str*>
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca\library\std\src\panicking.rs:521
   1: lightning::routing::gossip::tests::calling_sync_routing_table
             at .\src\routing\gossip.rs:2923
   2: lightning::routing::gossip::tests::calling_sync_routing_table::{{closure}}
             at .\src\routing\gossip.rs:2891
   3: core::ops::function::FnOnce::call_once<closure-0,tuple<>>
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca\library\core\src\ops\function.rs:227
   4: core::ops::function::FnOnce::call_once
             at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca\library\core\src\ops\function.rs:227
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    routing::gossip::tests::calling_sync_routing_table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant