Skip to content

Allow specifying retry strategy per-payment instead of globally #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue May 17, 2022 · 4 comments
Closed

Allow specifying retry strategy per-payment instead of globally #1487

TheBlueMatt opened this issue May 17, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@TheBlueMatt
Copy link
Collaborator

Probably should have thought of this before #1418, but oh well - ideally we'd be able to specify the payment retry count on a per-payment basis rather than globally in the InvoicePayer. This would likely imply refusing to retry things that weren't started using the InvoicePayer/after restart, but that may be okay? Would have to document that or make it configurable.

@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label May 17, 2022
@benthecarman
Copy link
Contributor

benthecarman commented Dec 19, 2022

Tried working on this, seems complications will come from handle_event_internal. Could simplify by keeping the current retry strategy as the default one and have the ability to pass an Option<Retry> when paying to override

@valentinewallace
Copy link
Contributor

Ah, this is being done as a side effect of #1916 and its follow-ups actually. Guess I'll self-assign.

@valentinewallace valentinewallace self-assigned this Dec 19, 2022
@acceleratesage
Copy link

It appears this issue is resolved. Could it be closed, or is there any further clarification needed?

@valentinewallace
Copy link
Contributor

It appears this issue is resolved. Could it be closed, or is there any further clarification needed?

Good point, yes this should be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants