Skip to content

Need to support decoding more onion types #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
TheBlueMatt opened this issue Oct 17, 2021 · 2 comments · Fixed by #1148
Closed

Need to support decoding more onion types #1129

TheBlueMatt opened this issue Oct 17, 2021 · 2 comments · Fixed by #1148
Milestone

Comments

@TheBlueMatt
Copy link
Collaborator

I received an onion failure after an MPP part timed out which log reported as unknown, i presume we're just out of date compared to BOLTs:

2021-10-17 20:33:13.537 WARN [lightning::ln::onion_utils:484] Onion Error[from ...: (0x17)] Unknown

@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Oct 17, 2021
@dunxen
Copy link
Contributor

dunxen commented Oct 29, 2021

I presume that was mpp_timeout? (EDIT: Yup type 23 I see) I think I will be able to tackle this. Will also get me more familiar with onion messages in the spec. Probably are a few other new ones we're missing support for.

@TheBlueMatt
Copy link
Collaborator Author

Yep, the correct type would have been mpp_timeout here. Indeed, I wouldn't be surprised if there were others.

@ConorOkus ConorOkus moved this to In Progress in LDK Roadmap Dec 7, 2021
Repository owner moved this from In Progress to Done in LDK Roadmap Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants