-
Notifications
You must be signed in to change notification settings - Fork 406
MPP receive timeout not implemented? #1050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hmm, I believe we currently fail it some blocks before the CLTV timeout, not on a timer, though I admit maybe that's not exactly a "reasonable timeout" |
In this case, what would be considered a Should we consider implementing a timer of sorts? |
I believe you really should indeed. Imagine the case where a sender splits a payment in two parts. If the sender is unable to find other routes to send the second part and abandons the payment, it will still have the first part locked for many blocks: this consumes liquidity for a long time for no good reason for every node in the path. |
If we have to setup a timer (seconds/minutes based) we would have to make it event-based, am I correct in this? |
While we don't assume access to the current time, we do have |
Might make sense if I take a look at this after #1148. |
Marking 0.1 cause this can interact natively with some senders to make a really poor UX. |
Busy working on this |
I'm testing the latest version of the ldk-sample and I noticed that the receiver MPP timeout mechanism doesn't seem to work.
I sent a partial HTLC to the LDK sample node, it's correctly accepted, but even after 5 minutes without receiving the remaining HTLCs the LDK sample node doesn't fail the incoming HTLC.
I'm referring to the following requirement:
Is that expected?
The text was updated successfully, but these errors were encountered: