Skip to content

Commit e4086b4

Browse files
committed
Drop the no-std feature from BP and drop feature implications
Now that we don't have to have everything in our entire ecosystem use the same `std`/`no-std` feature combinations we should start by untangling our own features a bit. This takes the first step by removing the `no-std` feature entirely from the `lightning-background-processor` crate and removing all feature implications on dependencies from the remaining `std` feature. It also addresses a CI oversight where we were not testing `lightning-background-processor` without the `std` feature in CI at all.
1 parent 15dbcf7 commit e4086b4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

ci/ci-tests.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ fi
6060

6161
echo -e "\n\nTest futures builds"
6262
cargo test -p lightning-background-processor --verbose --color always --features futures
63+
cargo test -p lightning-background-processor --verbose --color always --features futures --no-default-features
6364

6465
echo -e "\n\nTest Custom Message Macros"
6566
cargo test -p lightning-custom-message --verbose --color always

lightning-background-processor/Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ rustdoc-args = ["--cfg", "docsrs"]
1515

1616
[features]
1717
futures = [ ]
18-
std = ["bitcoin/std", "lightning/std", "lightning-rapid-gossip-sync/std"]
19-
no-std = ["lightning/no-std", "lightning-rapid-gossip-sync/no-std"]
18+
std = []
2019

2120
default = ["std"]
2221

0 commit comments

Comments
 (0)