Skip to content

Commit c4f2e48

Browse files
committed
Move lightning-transaction-sync out of the main workspace
Because `lightning-transaction-sync` does not have an MSRV (and because its dev-dependencies are huge), we can't build it by default when devs run `cargo test`, so it is moved out of the top-level workspace.
1 parent 80225e5 commit c4f2e48

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,10 @@ jobs:
8686
run: cargo update -p tokio --precise "1.14.0" --verbose
8787
env:
8888
CARGO_NET_GIT_FETCH_WITH_CLI: "true"
89-
- name: Build on Rust ${{ matrix.toolchain }} with net-tokio and tx-sync
90-
if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
89+
- name: Build on Rust ${{ matrix.toolchain }} with net-tokio
90+
if: "matrix.build-net-tokio && !matrix.coverage"
9191
run: cargo build --verbose --color always
92-
- name: Build on Rust ${{ matrix.toolchain }} with net-tokio, tx-sync, and full code-linking for coverage generation
92+
- name: Build on Rust ${{ matrix.toolchain }} with net-tokio, and full code-linking for coverage generation
9393
if: matrix.coverage
9494
run: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always
9595
- name: Build on Rust ${{ matrix.toolchain }}
@@ -138,9 +138,9 @@ jobs:
138138
run: |
139139
cd lightning && cargo test --verbose --color always --features backtrace
140140
- name: Test on Rust ${{ matrix.toolchain }} with net-tokio
141-
if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
141+
if: "matrix.build-net-tokio && !matrix.coverage"
142142
run: cargo test --verbose --color always
143-
- name: Test on Rust ${{ matrix.toolchain }} with net-tokio, tx-sync, and full code-linking for coverage generation
143+
- name: Test on Rust ${{ matrix.toolchain }} with net-tokio, and full code-linking for coverage generation
144144
if: matrix.coverage
145145
run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always
146146
- name: Test no-std builds on Rust ${{ matrix.toolchain }}

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
members = [
44
"lightning",
55
"lightning-block-sync",
6-
"lightning-transaction-sync",
76
"lightning-invoice",
87
"lightning-net-tokio",
98
"lightning-persister",
@@ -13,6 +12,7 @@ members = [
1312

1413
exclude = [
1514
"lightning-custom-message",
15+
"lightning-transaction-sync",
1616
"no-std-check",
1717
]
1818

0 commit comments

Comments
 (0)