keysinterface: add get_phantom_secret method

XXX elaborate

Author: valentinewallace

fuzz/src/chanmon_consistency.rs

@@ -223,6 +223,10 @@ impl KeysInterface for KeyProvider {
 	fn sign_invoice(&self, _invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> {
 		unreachable!()
 	}
+
+	fn get_phantom_secret(&self, _scid: u64) -> Result<SecretKey, ()> {
+		Ok(SecretKey::from_slice(&[0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, self.node_id]).unwrap())
+	}
 }
 
 impl KeyProvider {

fuzz/src/full_stack.rs

@@ -336,6 +336,10 @@ impl KeysInterface for KeyProvider {
 	fn sign_invoice(&self, _invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> {
 		unreachable!()
 	}
+
+	fn get_phantom_secret(&self, _scid: u64) -> Result<SecretKey, ()> {
+		Err(())
+	}
 }
 
 #[inline]

lightning/src/chain/keysinterface.rs

@@ -30,6 +30,7 @@ use bitcoin::secp256k1::recovery::RecoverableSignature;
 use bitcoin::secp256k1;
 
 use util::{byte_utils, transaction_utils};
+use util::crypto::hkdf_extract_expand;
 use util::ser::{Writeable, Writer, Readable};
 
 use chain::transaction::OutPoint;
@@ -408,6 +409,9 @@ pub trait KeysInterface {
 	///
 	/// This method must return the same value each time it is called.
 	fn get_inbound_payment_key_material(&self) -> KeyMaterial;
+
+	/// XXX
+	fn get_phantom_secret(&self, scid: u64) -> Result<SecretKey, ()>; // XXX better error?
 }
 
 #[derive(Clone)]
@@ -1109,6 +1113,11 @@ impl KeysInterface for KeysManager {
 	fn sign_invoice(&self, invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> {
 		Ok(self.secp_ctx.sign_recoverable(&hash_to_message!(&Sha256::hash(&invoice_preimage)), &self.get_node_secret()))
 	}
+
+	fn get_phantom_secret(&self, _scid: u64) -> Result<SecretKey, ()> {
+		let hkdf = hkdf_extract_expand(b"LDK Phantom Node Secret Key Expansion", &self.inbound_payment_key.0, 1);
+		Ok(SecretKey::from_slice(&hkdf[0]).unwrap())
+	}
 }
 
 // Ensure that BaseSign can have a vtable

lightning/src/ln/channel.rs

@@ -5877,6 +5877,7 @@ mod tests {
 		fn get_secure_random_bytes(&self) -> [u8; 32] { [0; 32] }
 		fn read_chan_signer(&self, _data: &[u8]) -> Result<Self::Signer, DecodeError> { panic!(); }
 		fn sign_invoice(&self, _invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> { panic!(); }
+		fn get_phantom_secret(&self, _scid: u64) -> Result<SecretKey, ()> { panic!(); }
 	}
 
 	fn public_from_secret_hex(secp_ctx: &Secp256k1<All>, hex: &str) -> PublicKey {

lightning/src/util/test_utils.rs

@@ -88,6 +88,7 @@ impl keysinterface::KeysInterface for OnlyReadsKeysInterface {
 		))
 	}
 	fn sign_invoice(&self, _invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> { unreachable!(); }
+	fn get_phantom_secret(&self, _scid: u64) -> Result<SecretKey, ()> { unreachable!(); }
 }
 
 pub struct TestChainMonitor<'a> {
@@ -530,6 +531,8 @@ impl keysinterface::KeysInterface for TestKeysInterface {
 	fn sign_invoice(&self, invoice_preimage: Vec<u8>) -> Result<RecoverableSignature, ()> {
 		self.backing.sign_invoice(invoice_preimage)
 	}
+
+	fn get_phantom_secret(&self, scid: u64) -> Result<SecretKey, ()> { self.backing.get_phantom_secret(scid) }
 }
 
 impl TestKeysInterface {