Skip to content

Commit b7a59d4

Browse files
committed
Extract locks in async_signer_tests.rs
1 parent 05e1071 commit b7a59d4

File tree

1 file changed

+15
-24
lines changed

1 file changed

+15
-24
lines changed

lightning/src/ln/async_signer_tests.rs

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -602,14 +602,11 @@ fn do_test_async_raa_peer_disconnect(
602602
if test_case == UnblockSignerAcrossDisconnectCase::BeforeMonitorRestored {
603603
dst.enable_channel_signer_op(&src.node.get_our_node_id(), &chan_id, block_raa_signer_op);
604604
chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
605-
let (latest_update, _) = dst
606-
.chain_monitor
607-
.latest_monitor_update_id
608-
.lock()
609-
.unwrap()
610-
.get(&chan_id)
611-
.unwrap()
612-
.clone();
605+
let latest_update;
606+
{
607+
let channel_map = dst.chain_monitor.latest_monitor_update_id.lock().unwrap();
608+
(latest_update, _) = channel_map.get(&chan_id).unwrap().clone();
609+
}
613610
dst.chain_monitor.chain_monitor.force_channel_monitor_updated(chan_id, latest_update);
614611
check_added_monitors!(dst, 0);
615612
}
@@ -766,14 +763,11 @@ fn do_test_async_commitment_signature_peer_disconnect(
766763
SignerOp::SignCounterpartyCommitment,
767764
);
768765
chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
769-
let (latest_update, _) = dst
770-
.chain_monitor
771-
.latest_monitor_update_id
772-
.lock()
773-
.unwrap()
774-
.get(&chan_id)
775-
.unwrap()
776-
.clone();
766+
let latest_update;
767+
{
768+
let channel_map = dst.chain_monitor.latest_monitor_update_id.lock().unwrap();
769+
(latest_update, _) = channel_map.get(&chan_id).unwrap().clone();
770+
}
777771
dst.chain_monitor.chain_monitor.force_channel_monitor_updated(chan_id, latest_update);
778772
check_added_monitors!(dst, 0);
779773
}
@@ -918,14 +912,11 @@ fn do_test_async_commitment_signature_ordering(monitor_update_failure: bool) {
918912

919913
if monitor_update_failure {
920914
chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
921-
let (latest_update, _) = nodes[0]
922-
.chain_monitor
923-
.latest_monitor_update_id
924-
.lock()
925-
.unwrap()
926-
.get(&chan_id)
927-
.unwrap()
928-
.clone();
915+
let latest_update;
916+
{
917+
let channel_map = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap();
918+
(latest_update, _) = channel_map.get(&chan_id).unwrap().clone();
919+
}
929920
nodes[0].chain_monitor.chain_monitor.force_channel_monitor_updated(chan_id, latest_update);
930921
check_added_monitors!(nodes[0], 0);
931922
}

0 commit comments

Comments
 (0)