Skip to content

Commit 77b35bb

Browse files
committed
Remove the bindings crate from the root namespace to let it break
Until we get the bindings generation process super stable, let the bindings get stale with respect to the main repo while still letting `cargo check` pass.
1 parent 83322e1 commit 77b35bb

File tree

3 files changed

+7
-1
lines changed

3 files changed

+7
-1
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ jobs:
127127
apt-get -y install cargo valgrind lld git g++ clang
128128
- name: Checkout source code
129129
uses: actions/checkout@v2
130+
- name: Sanity test bindings
131+
run: cd lightning-c-bindings && cargo check && cd ..
130132
- name: Install cbindgen
131133
run: cargo install --force cbindgen
132134
- name: Rebuild bindings, and check the sample app builds + links

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
members = [
44
"lightning",
55
"lightning-net-tokio",
6-
"lightning-c-bindings",
76
]
87

98
# Our tests do actual crypo and lots of work, the tradeoff for -O1 is well worth it

lightning-c-bindings/Cargo.toml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,3 +17,8 @@ crate-type = ["staticlib"
1717
[dependencies]
1818
bitcoin = "0.24"
1919
lightning = { version = "0.0.11", path = "../lightning" }
20+
21+
# We eventually want to join the root workspace, but for now, the bindings generation is
22+
# a bit brittle and we don't want to hold up other developers from making changes just
23+
# because they break the bindings
24+
[workspace]

0 commit comments

Comments
 (0)