Skip to content

Unified interface listing all available balances #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tnull opened this issue Dec 1, 2023 · 0 comments · Fixed by #250
Closed

Unified interface listing all available balances #212

tnull opened this issue Dec 1, 2023 · 0 comments · Fixed by #250
Milestone
0.3

Comments

@tnull
Copy link
Collaborator

tnull commented Dec 1, 2023 •
edited
Loading

We need to give the user insight into when balances are claimable / delayed outputs will be ready. A short-term solution would be to hand-through ChainMonitor::get_claimable_balances. However, this would require the user to query 2-3 different APIs go get a good overview of what is going on.

We therefore should introduce a unified interface (enum Balance ?) with variants for on-chain (possibly re-using bdk::balance), delayed/claimable (possibly wrapping LDK's Balance) and "spend in-progress" that reflects the state of outputs that are not listed as part of get_claimable_balance anymore but pending sweeping / on-chain confirmation.
@tnull tnull changed the title Expose get_claimable_balances Allow insight into claimable balances Dec 1, 2023
@tnull tnull changed the title Allow insight into claimable balances Allow insight into all available balances Dec 1, 2023
@tnull tnull added this to the 0.3 milestone Dec 1, 2023
@tnull tnull changed the title Allow insight into all available balances Unified interface exposing all available balances according to their corresponding states Dec 1, 2023
@tnull tnull changed the title Unified interface exposing all available balances according to their corresponding states Unified interface listing all available balances Dec 1, 2023
This was referenced Feb 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3
Development

Successfully merging a pull request may close this issue.

Expose unified list_balances interface method tnull/ldk-node
1 participant
@tnull