Skip to content

Commit a98d756

Browse files
committed
Bump MSRV to rustc 1.75
Recently, `rustls` bumped their MSRV to 1.71. As we depend on them and don't want to continuously pin this security-critical dependency back, we're looking to bump our MSRV to a version >= 1.71, too. Here, we propose to bump the MSRV to rustc version 1.75, which was chosen because: a) it's > 1 year old b) it provides a buffer to 1.71, i.e., if some crate bumped to a version > 1.71, there is a chance we don't immediately have to react again c) it stabilized `async fn`s in traits (see https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html), which might become handy for related crates.
1 parent 20a6927 commit a98d756

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

.github/workflows/rust.yml

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
toolchain: [
1919
stable,
2020
beta,
21-
1.63.0, # Our MSRV
21+
1.75.0, # Our MSRV
2222
]
2323
include:
2424
- toolchain: stable
@@ -29,7 +29,7 @@ jobs:
2929
platform: macos-latest
3030
- toolchain: stable
3131
platform: windows-latest
32-
- toolchain: 1.63.0
32+
- toolchain: 1.75.0
3333
msrv: true
3434
runs-on: ${{ matrix.platform }}
3535
steps:
@@ -45,13 +45,7 @@ jobs:
4545
- name: Pin packages to allow for MSRV
4646
if: matrix.msrv
4747
run: |
48-
cargo update -p proptest --precise "1.2.0" --verbose # proptest 1.3.0 requires rustc 1.64.0
49-
cargo update -p regex --precise "1.9.6" --verbose # regex 1.10.0 requires rustc 1.65.0
50-
cargo update -p home --precise "0.5.5" --verbose # home v0.5.9 requires rustc 1.70 or newer
51-
cargo update -p tokio --precise "1.38.1" --verbose # tokio v1.39.0 requires rustc 1.70 or newer
52-
cargo update -p tokio-util --precise "0.7.11" --verbose # tokio-util v0.7.12 requires rustc 1.70 or newer
53-
cargo update -p idna_adapter --precise "1.1.0" --verbose # url 2.5.3 switched to idna 1.0.3 and ICU4X, which requires rustc 1.67 or newer. Here we opt to keep using unicode-rs by pinning idna_adapter as described here: https://docs.rs/crate/idna_adapter/1.2.0
54-
cargo update -p indexmap --precise "2.5.0" --verbose # indexmap 2.6.0 upgraded to hashbrown 0.15, which unfortunately bumped their MSRV to rustc 1.65 with the 0.15.1 release
48+
cargo update -p home --precise "0.5.9" --verbose # home v0.5.11 requires rustc 1.81 or newer
5549
- name: Set RUSTFLAGS to deny warnings
5650
if: "matrix.toolchain == 'stable'"
5751
run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
@@ -84,7 +78,7 @@ jobs:
8478
if: matrix.build-uniffi
8579
run: cargo build --features uniffi --verbose --color always
8680
- name: Build documentation on Rust ${{ matrix.toolchain }}
87-
if: "matrix.platform != 'windows-latest' || matrix.toolchain != '1.63.0'"
81+
if: "matrix.platform != 'windows-latest' || matrix.toolchain != '1.75.0'"
8882
run: |
8983
cargo doc --release --verbose --color always
9084
cargo doc --document-private-items --verbose --color always

0 commit comments

Comments
 (0)