Animation 'animating' and 'stopped' events #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IAnimationController is now an event emitter. - `waitUntilStarted()` has been replaced by the 'animating' event - Added 'stopped' event. - `waitUntilStopped()` promised is now created more consistently - Excess `dt` that depletes a delay is now applied to the animation progress
frank-weindel
requested review from
erikhaandrikman,
jfboeve,
michielvandergeest and
wouterlucas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
waitUntilStarted()has been replaced by the 'animating' eventwaitUntilStopped()promised is now created more consistentlydtthat depletes a delay is now applied to the animation progressRedo of #274 since it got accidentally merged into the wrong branch