Restore the debug package, working on Java 11

[dwijnand]

In scala/community-build#796 (comment) Seth indicated that ssl-config was the big blocker for the scala community build on Java 11, which was being tracked at #98.

So I opened #138 and after being able to compile on Java 11 it turned out there was some code in the debug subpackage that relied on privileged reflection, that is actually enforced as of Java 11. As such ssl-config's tests didn't pass when run on Java 11.

In an attempt to keep moving I tried deleting the whole subpackage which seemed to pass the community build, but it actually turned out to fail on in play-ws, because those debug API are used (they're also used in the play repo proper, and potentially in more places).

The plan is to restore the package, but backed by @wsargent's https://github.com/tersesystems/debugjsse and https://github.com/tersesystems/ocapjsse#logging.

@wsargent could you take care of this, please?

[dwijnand]

There's nothing interesting on master since v0.3.7 so this isn't as urgent as I thought.

But it is a blocker for any future release, as we shouldn't push out an artifact without these binary APIs!

[dwijnand]

Will also shared https://tersesystems.com/blog/2014/03/02/monkeypatching-java-classes/

[wsargent]

@dwijnand Will do!

[dwijnand]

Just wanted to mention that this is still on my mind.

Master is currently unreleasable because it breaks binary compatibility. We don't have any immediate need to release, but I don't want to risk forgetting.

If we can't resolve this using your libraries, Will, I think we might have to restore the previous classes and re-fork the repo for the Java 11 community build (cc @SethTisue).

[wsargent]

@dwijnand Added work in progress -- am working on adding tests right now for keymanager/trustmanager but you can see how logging works with wrapper.

[dwijnand]

Thanks, Will. I pushed a commit to ensure we restore all the binary APIs.

[wsargent]

Addressed in #143 and playframework/playframework#8828

[SethTisue]

can we close this out? can #143 be merged?

[dwijnand]

Fixed in #143.

[wsargent]

Should this be reopened?

[dwijnand]

For what reason?

The package was restored, and it works on Java 11: https://travis-ci.org/lightbend/ssl-config/builds/515764092