feat: refactor to use async/await #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Refs ipfs/js-ipfs#1670 |
Contributor
|
I switched CI over to travis (it was still on jenkins) if you want to rebase this. |
achingbrain
force-pushed
the
async-await
branch
2 times, most recently
from
5ba7dfa to
0e110eb
Compare
Member
Author
|
Rebased! |
Member
Author
alanshaw
reviewed
Jul 10, 2019
alanshaw
pushed a commit
that referenced
this pull request
Jul 10, 2019
Depends on: * [ ] ipfs-inactive/js-ipfs-http-client#1039 cc @achingbrain License: MIT Signed-off-by: Alan Shaw <[email protected]>
alanshaw
pushed a commit
that referenced
this pull request
Jul 10, 2019
Needed for next js-ipfs release. Had to port some changes from #7 Depends on: * [ ] ipfs-inactive/js-ipfs-http-client#1039 cc @achingbrain License: MIT Signed-off-by: Alan Shaw <[email protected]>
Contributor
|
@achingbrain 0.2.3 is out if you want to rebase this bad boy |
Member
Author
|
Needs ipfs/js-ipfsd-ctl#356 |
Member
Author
|
|
BREAKING CHANGE: API refactored to use async/await
jacobheun
approved these changes
Jul 12, 2019
Contributor
jacobheun
left a comment
jacobheun
left a comment
There was a problem hiding this comment.
This looks good. 2/3rds of the missing codecov lines are due to the .aegir.js file changes, which it really shouldn't be picking up, so we can ignore the drop here.
| options = options || {} | ||
| } | ||
|
|
||
| async * findProviders (key, options = {}) { |
Contributor
There was a problem hiding this comment.
👍 it will be nice to have an iterable api all ready to go once the dht supports it.
Member
Author
There was a problem hiding this comment.
Death to lists. Iterate all of the things.
Seriously, it's going to alleviate so many memory problems..
Contributor
|
Released in v0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still got a couple of tests failing and some weirdness around the upgrade from
ipfs-apitoipfs-http-client.Depends on ipfs/js-ipfsd-ctl#353