Update build scripts #104
Merged
Update build scripts #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `set -e` to exit the build script immediately upon failure and propagate that build error to the caller.
ethomson
force-pushed
the
ethomson/update_libgit2
branch
2 times, most recently
from
72c33cc to
1c25754
Compare
libgit2 now requires a cmake from within the most recent half decade. Use a newer version during the build.
ethomson
force-pushed
the
ethomson/update_libgit2
branch
from
1c25754 to
55210cc
Compare
bording
reviewed
Oct 16, 2019
| COPY . /nativebinaries/ | ||
|
|
||
| RUN apt update && apt -y install cmake libssl-dev pkg-config | ||
| RUN apt update && apt -y install libssl-dev pkg-config curl make gcc build-essential |
Member
There was a problem hiding this comment.
Out of curiosity, why did you remove the old cmake from being installed here, but didn't alter it in the same way for the rhel-x64 file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the build scripts to produce a
linux-x64package.The build scripts will now propagate failures, so CI runs will fail if artifacts were not produced (instead of giving the appearance of success, and ultimately producing nupkgs that lacked the artifacts). The linux and rhel images now install a newer version of cmake, required for building libgit2.