String interpolation, list and !important keyword

[SomMeri]

I noticed something odd about string interpolation and lists:

.test-list {
  content: "@{variable}" !important;
  @variable: This is !important;
}

compiles into:

.test-list {
  content: "This is" !important;
}

I would expect it to be:

.test-list {
  content: "This is !important" !important;
}

I think it is just a minor issue, because following works correctly:

.test-string {
  content: "@{variable}" !important;
  @variable: "This is !important";
}

[lukeapage]

Its weird though.. intrigues me..

[lukeapage]

To fix this, you would change quoted to add a new important scope so that interpolating variables doesn't set important on the rule it is used in. In addition you would have to change variable interpolation to add !important to the quoted value.

But I'm having 2nd thoughts. Take this

.test-list {
  color1: "@{color}";
  color2: ~"@{color}";
  color3: ~"@{color}" !important;
  @color: black !important;
}

gives

.test-list {
  color1: "black" !important;
  color2: black !important;
  color3: black !important;
}

Now, this seems more useful to me.. I can't think of a solid example either way, so now I'm wondering whether to change it...

[matthew-dean]

That seems interesting but not critical, since it looks like it only has slightly different behavior with !important?

[lukeapage]

not sure I understand - that is the bug.

[matthew-dean]

I know, what I meant to say is that it seems like it would rarely, if ever, be encountered, if it only happens with @SomMeri's specific construction. The collapse of !important (like your example) seems intuitive, since you'd never want !important !important.