-
Notifications
You must be signed in to change notification settings - Fork 254
Fix trash page pagination #5552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: hotfixes
Are you sure you want to change the base?
Fix trash page pagination #5552
Conversation
bjester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm seeing that newly deleted nodes end up at the end of the trash list, when they should be at the top. I do not observe this on production, so it feels like it must be related to these changes.
After deleting Sparkfun-RPi5, it appeared at the bottom. A clue to the issue might be the modified time, for when it was deleted, because that isn't correct. After refreshing the page, the order is correct.
| Before Refresh | After Refresh |
|---|---|
![]() |
![]() |
bjester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing content, the sorting of content in trash, and the pagination of trash, all seem to function as expected. Setting modified during the move operation makes sense to properly order content in trash, and I see that does not prompt a sync of that information either. I will merge, but would be good to have @rtibbles still provide thoughts on that, if he has any.
|
@ozer550 ah just noticed some tests are failing, likely due to the move operation changes. |
|
It doesn't trigger a sync operation because of this, right?
I guess the only possible danger here is if the client side clock is completely out of whack with the server clock, which might cause some slight unpredictability (if your clock is 100 years in the past, then your newly deleted node will not be top of the list) - but that seems like an edge case we can ignore for now. As the modified field will also be updated on the backend, new data fetching on the frontend will overwrite the client side only change - so I think this all seems OK to me! |


Summary
References
Reviewer guidance