Skip to content

Conversation

@ozer550
Copy link
Member

@ozer550 ozer550 commented Nov 13, 2025

Summary

  • Cleared the trash Vuex cache and reset pagination flags, so reopening the modal always starts from page one.

References

Reviewer guidance

  • Delete a large number of resources and open the channel's Trash page
  • Clicking several times on 'Show more' works now with proper pagination.
  • Close the modal and reopen it
  • It still works with pagination getting reset.

@ozer550 ozer550 changed the base branch from unstable to hotfixes November 13, 2025 06:27
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing that newly deleted nodes end up at the end of the trash list, when they should be at the top. I do not observe this on production, so it feels like it must be related to these changes.

After deleting Sparkfun-RPi5, it appeared at the bottom. A clue to the issue might be the modified time, for when it was deleted, because that isn't correct. After refreshing the page, the order is correct.

Before Refresh After Refresh
Image Image

@ozer550 ozer550 requested review from bjester and rtibbles November 24, 2025 06:55
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing content, the sorting of content in trash, and the pagination of trash, all seem to function as expected. Setting modified during the move operation makes sense to properly order content in trash, and I see that does not prompt a sync of that information either. I will merge, but would be good to have @rtibbles still provide thoughts on that, if he has any.

@bjester
Copy link
Member

bjester commented Dec 1, 2025

@ozer550 ah just noticed some tests are failing, likely due to the move operation changes.

@rtibbles
Copy link
Member

rtibbles commented Dec 1, 2025

It doesn't trigger a sync operation because of this, right?

// Do direct table writes here rather than using add/update methods to avoid
// creating unnecessary additional change events.

I guess the only possible danger here is if the client side clock is completely out of whack with the server clock, which might cause some slight unpredictability (if your clock is 100 years in the past, then your newly deleted node will not be top of the list) - but that seems like an edge case we can ignore for now.

As the modified field will also be updated on the backend, new data fetching on the frontend will overwrite the client side only change - so I think this all seems OK to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hotfixes - Channel trash - Closing the Trash modal doesn't reset the pagination state

3 participants