Skip to content

Support pass in dataclass #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 22, 2023
Merged

Support pass in dataclass #1997

merged 4 commits into from
Jun 22, 2023

Conversation

ubaidsk
Copy link
Collaborator

@ubaidsk ubaidsk commented Jun 22, 2023

fixes #1988

This PR also replaces the LCOMPILERS_ASSERT for AnnAssign with a SemanticError.

@ubaidsk ubaidsk force-pushed the pass_in_dataclass branch from b203397 to 304107f Compare June 22, 2023 05:25
certik
certik approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, thanks!

@certik certik merged commit 336168b into lcompilers:main Jun 22, 2023
@ubaidsk ubaidsk deleted the pass_in_dataclass branch June 22, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"pass" in dataclass asserts
2 participants
@ubaidsk @certik