Merge pull request #1816 from Shaikh-Ubaid/remove_unneeded_variable

certik · web-flow · commit 6e5595eea3a1 · 2023-05-16T11:12:58.000-06:00
Minor: Remove unneeded variable
diff --git a/src/lpython/semantics/python_ast_to_asr.cpp b/src/lpython/semantics/python_ast_to_asr.cpp
@@ -894,14 +894,13 @@ class CommonVisitor : public AST::BaseVisitor<Struct> {
     }
 
     int64_t find_argument_position_from_name(ASR::StructType_t* orig_struct, std::string arg_name) {
-        int64_t arg_position = -1;
         for( size_t i = 0; i < orig_struct->n_members; i++ ) {
             std::string original_arg_name = std::string(orig_struct->m_members[i]);
             if( original_arg_name == arg_name ) {
                 return i;
             }
         }
-        return arg_position;
+        return -1;
     }
 
     void visit_expr_list(AST::expr_t** pos_args, size_t n_pos_args,

Original file line number	Diff line number	Diff line change
`@@ -894,14 +894,13 @@ class CommonVisitor : public AST::BaseVisitor<Struct> {`
`894`	`894`	`}`
`895`	`895`
`896`	`896`	`int64_t find_argument_position_from_name(ASR::StructType_t* orig_struct, std::string arg_name) {`
`897`		`- int64_t arg_position = -1;`
`898`	`897`	`for( size_t i = 0; i < orig_struct->n_members; i++ ) {`
`899`	`898`	`std::string original_arg_name = std::string(orig_struct->m_members[i]);`
`900`	`899`	`if( original_arg_name == arg_name ) {`
`901`	`900`	`return i;`
`902`	`901`	`}`
`903`	`902`	`}`
`904`		`- return arg_position;`
	`903`	`+ return -1;`
`905`	`904`	`}`
`906`	`905`
`907`	`906`	`void visit_expr_list(AST::expr_t** pos_args, size_t n_pos_args,`