Refactor: WASM_X86: Directly push value onto stack

ubaidsk · ubaidsk · commit 2b0e213b0996 · 2022-11-11T16:22:04.000+05:30
diff --git a/src/libasr/codegen/wasm_to_x86.cpp b/src/libasr/codegen/wasm_to_x86.cpp
@@ -225,12 +225,11 @@ class X86Visitor : public WASMDecoder<X86Visitor>,
         } else {
             throw CodeGenError("Comparison operator not implemented");
         }
-        m_a.asm_mov_r32_imm32(X86Reg::eax, 0);
+        m_a.asm_push_imm8(0);
         m_a.asm_jmp_label(".compare.end_" + label);
         m_a.add_label(".compare_1" + label);
-        m_a.asm_mov_r32_imm32(X86Reg::eax, 1);
+        m_a.asm_push_imm8(1);
         m_a.add_label(".compare.end_" + label);
-        m_a.asm_push_r32(X86Reg::eax);
     }
 
     void visit_I32Eq() { handle_I32Compare("Eq"); }

Original file line number	Diff line number	Diff line change
`@@ -225,12 +225,11 @@ class X86Visitor : public WASMDecoder<X86Visitor>,`
`225`	`225`	`} else {`
`226`	`226`	`throw CodeGenError("Comparison operator not implemented");`
`227`	`227`	`}`
`228`		`- m_a.asm_mov_r32_imm32(X86Reg::eax, 0);`
	`228`	`+ m_a.asm_push_imm8(0);`
`229`	`229`	`m_a.asm_jmp_label(".compare.end_" + label);`
`230`	`230`	`m_a.add_label(".compare_1" + label);`
`231`		`- m_a.asm_mov_r32_imm32(X86Reg::eax, 1);`
	`231`	`+ m_a.asm_push_imm8(1);`
`232`	`232`	`m_a.add_label(".compare.end_" + label);`
`233`		`- m_a.asm_push_r32(X86Reg::eax);`
`234`	`233`	`}`
`235`	`234`
`236`	`235`	`void visit_I32Eq() { handle_I32Compare("Eq"); }`