diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2d92aab..0d33d58 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,6 +14,7 @@ jobs: runs-on: ubuntu-latest strategy: + fail-fast: false matrix: ruby-version: - '2.5' @@ -22,7 +23,6 @@ jobs: - '3.0' - '3.1' - '3.2' - - jruby-9.2 - jruby-9.3 - jruby-9.4 diff --git a/lib/ld-eventsource/client.rb b/lib/ld-eventsource/client.rb index e677446..6355a62 100644 --- a/lib/ld-eventsource/client.rb +++ b/lib/ld-eventsource/client.rb @@ -141,9 +141,7 @@ def initialize(uri, yield self if block_given? - Thread.new do - run_stream - end + Thread.new { run_stream }.name = 'LD/SSEClient' end # diff --git a/scripts/gendocs.sh b/scripts/gendocs.sh deleted file mode 100755 index 45ff28c..0000000 --- a/scripts/gendocs.sh +++ /dev/null @@ -1,12 +0,0 @@ -#!/bin/bash - -# Use this script to generate documentation locally in ./doc so it can be proofed before release. -# After release, documentation will be visible at https://www.rubydoc.info/gems/ld-eventsource - -gem install --conservative yard -gem install --conservative redcarpet # provides Markdown formatting - -# yard doesn't seem to do recursive directories, even though Ruby's Dir.glob supposedly recurses for "**" -PATHS="lib/*.rb lib/**/*.rb lib/**/**/*.rb" - -yard doc --no-private --markup markdown --markup-provider redcarpet --embed-mixins $PATHS - README.md diff --git a/scripts/release.sh b/scripts/release.sh deleted file mode 100755 index 81aac06..0000000 --- a/scripts/release.sh +++ /dev/null @@ -1,30 +0,0 @@ -#!/usr/bin/env bash - -# This script updates the version for the library and releases it to RubyGems -# It will only work if you have the proper credentials set up in ~/.gem/credentials - -# It takes exactly one argument: the new version. -# It should be run from the root of this git repo like this: -# ./scripts/release.sh 4.0.9 - -# When done you should commit and push the changes made. - -set -uxe - -VERSION=$1 -GEM_NAME=ld-eventsource - -echo "Starting $GEM_NAME release." - -# Update version in version.rb -VERSION_RB_TEMP=./version.rb.tmp -sed "s/VERSION =.*/VERSION = \"${VERSION}\"/g" lib/$GEM_NAME/version.rb > ${VERSION_RB_TEMP} -mv ${VERSION_RB_TEMP} lib/$GEM_NAME/version.rb - -# Build Ruby gem -gem build $GEM_NAME.gemspec - -# Publish Ruby gem -gem push $GEM_NAME-${VERSION}.gem - -echo "Done with $GEM_NAME release" \ No newline at end of file