-
Notifications
You must be signed in to change notification settings - Fork 45
Support new description syntax #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@jlengstorf thanks for the issue. Support for the new description syntax is in the latest release. |
@kumarharsh Nice! was there a new release cut with this change, or is that still forthcoming? |
Yes, there was a new release. |
I'm having trouble finding it. It seems to be missing on the github releases tab and it's not showing up under "More Info" on the vscode project. |
Yeah, it's stuck in publishing - apparently my Visual Studio Publish Token had expired and I'm weirdly locked out of the account from which the token was generated. I'm working to get things working again. |
Hi, I'm still not able to restore the publishing process and working on it. Please try out this release, and let me know if things work fine, i.e., if this issue has been resolved: |
Yep, this works great, thanks!. Good luck figuring out the publishing process 😕 |
Yeah, it's a rabbit hole of accounts and permissions and what not 😟 |
@kumarharsh I installed from the VSIX and it doesn't appear to support the string syntax: Is there a setting I need to tweak? |
I believe this may be my fault, because I didn't include the single-line string syntax in the example above. Sorry about that! 😕 |
Ah yeah, it seems as though the triple quote and single quote should both be supported as valid single line descriptions - I only tried with the |
I misread the linked issue and spec, they do state "any leading string". |
@kumarharsh Thanks for updating this! Is there a link to the new release and/or an ETA for it landing in the VS Code marketplace? |
Yes, it should be there now. |
@Grmiade it's an issue with the |
In the meantime, if you want to specify:
in your dependencies it should work. I'll keep that branch up until something gets merged upstream. |
Thanks @tgriesser, indeed it works 👍 |
As of v0.12.0, field descriptions need to be represented as strings rather than comments.
That means that the following schema:
Needs to be rewritten as:
Syntax highlighting should be updated to reflect the string type; right now it looks pretty wonky.
The text was updated successfully, but these errors were encountered: