Skip to content

Support new description syntax #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jlengstorf opened this issue Dec 22, 2017 · 18 comments
Closed

Support new description syntax #63

jlengstorf opened this issue Dec 22, 2017 · 18 comments

Comments

@jlengstorf
Copy link

As of v0.12.0, field descriptions need to be represented as strings rather than comments.

That means that the following schema:

type Query {
  # Receive a greeting.
  hello: String
}

Needs to be rewritten as:

type Query {
  """
  Receive a greeting.
  """
  hello: String
}

Syntax highlighting should be updated to reflect the string type; right now it looks pretty wonky.

screencap-by-jlengstorf 26

@kumarharsh
Copy link
Owner

@jlengstorf thanks for the issue. Support for the new description syntax is in the latest release.

@tgriesser
Copy link

@kumarharsh Nice! was there a new release cut with this change, or is that still forthcoming?

@kumarharsh
Copy link
Owner

Yes, there was a new release.

@tgriesser
Copy link

I'm having trouble finding it. It seems to be missing on the github releases tab and it's not showing up under "More Info" on the vscode project.

@kumarharsh
Copy link
Owner

Yeah, it's stuck in publishing - apparently my Visual Studio Publish Token had expired and I'm weirdly locked out of the account from which the token was generated. I'm working to get things working again.

@kumarharsh
Copy link
Owner

kumarharsh commented Jan 10, 2018

Hi, I'm still not able to restore the publishing process and working on it.

Please try out this release, and let me know if things work fine, i.e., if this issue has been resolved:
https://1drv.ms/u/s!ArGqE3U0XhYmu5BCpISKDIQgbuMo9g

@tgriesser
Copy link

tgriesser commented Jan 10, 2018

Yep, this works great, thanks!. Good luck figuring out the publishing process 😕

@kumarharsh
Copy link
Owner

Good luck figuring out the publishing process 😕

Yeah, it's a rabbit hole of accounts and permissions and what not 😟

@jlengstorf
Copy link
Author

@kumarharsh I installed from the VSIX and it doesn't appear to support the string syntax:

screencap-by-jlengstorf 49

Is there a setting I need to tweak?

@jlengstorf
Copy link
Author

I believe this may be my fault, because I didn't include the single-line string syntax in the example above. Sorry about that! 😕

@tgriesser
Copy link

Ah yeah, it seems as though the triple quote and single quote should both be supported as valid single line descriptions - I only tried with the """ multi-line.

@kumarharsh kumarharsh reopened this Jan 11, 2018
@kumarharsh
Copy link
Owner

I misread the linked issue and spec, they do state "any leading string".

@jlengstorf
Copy link
Author

@kumarharsh Thanks for updating this! Is there a link to the new release and/or an ETA for it landing in the VS Code marketplace?

@kumarharsh
Copy link
Owner

Yes, it should be there now.

@Grmiade
Copy link

Grmiade commented Mar 7, 2018

I have this syntax error. Is not the new description syntax is not supported?
(I use the 1.9.0 version of the extension)

capture d ecran 2018-03-07 a 23 22 43

@tgriesser
Copy link

@Grmiade it's an issue with the @playlyfe/gql dependency - I opened a PR here Mayank1791989/gql#111

@tgriesser
Copy link

In the meantime, if you want to specify:

"@playlyfe/gql": "tgriesser/gql.git#upgrade-deps-published",

in your dependencies it should work. I'll keep that branch up until something gets merged upstream.

@Grmiade
Copy link

Grmiade commented Mar 8, 2018

Thanks @tgriesser, indeed it works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants