-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Allow cluster-autoscaler to list/watch StatefulSets #3202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Otherwise we get the error
k8s.io/autoscaler/cluster-autoscaler/vendor/k8s.io/kubernetes/pkg/client/informers/informers_generated/externalversions/factory.go:72: Failed to list *v1beta1.StatefulSet: User "system:serviceaccount:kube-system:cluster-autoscaler" cannot list statefulsets.apps at the cluster scope. (get statefulsets.apps)
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hi @carlossg. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@carlossg are you able to sign the CLA? It can be a bit of a burden, but then the same CLA applies to all kubernetes projects. |
|
yeah, I'm in the process of doing it. May take a while though |
|
CLA signed |
|
/assign @sethpollack @andrewsykim Can one of you peeps take a look? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, chrislovecnm The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/ok-to-test |
|
Automatic merge from submit-queue. . |
Otherwise we get the error