-
Notifications
You must be signed in to change notification settings - Fork 1.6k
✨ (go/v4): Added DevContainer support for seamless development in environments like GitHub Workspaces without local setup. #4078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: Test DevContainer Image | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| test-devcontainer: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Setup Go 1.22.x | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: "1.22.x" | ||
|
|
||
| - name: Setup NodeJS 20.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "20.x" | ||
|
|
||
| - name: Setup Devcontainer CLI | ||
| run: | | ||
| npm install -g @devcontainers/cli | ||
|
|
||
| - name: Build and Validate DevContainer | ||
| run: | | ||
| cd testdata/project-v4 | ||
|
|
||
| OUTPUT=$(devcontainer up --workspace-folder=./) | ||
| STATUS=$(echo "$OUTPUT" | jq -r '.outcome') | ||
|
|
||
| if [[ "$STATUS" == "success" ]]; then | ||
| echo "Devcontainer setup was successful." | ||
| exit 0 | ||
| else | ||
| echo "Devcontainer setup failed." | ||
| exit 1 | ||
| fi | ||
TAM360 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
25 changes: 25 additions & 0 deletions
25
docs/book/src/cronjob-tutorial/testdata/project/.devcontainer/devcontainer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "name": "Kubebuilder DevContainer", | ||
| "image": "golang:1.22", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
|
|
||
| "runArgs": ["--network=host"], | ||
|
|
||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" | ||
| }, | ||
| "extensions": [ | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-docker" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| "onCreateCommand": "bash .devcontainer/post-install.sh" | ||
| } | ||
|
|
23 changes: 23 additions & 0 deletions
23
docs/book/src/cronjob-tutorial/testdata/project/.devcontainer/post-install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/bin/bash | ||
| set -x | ||
|
|
||
| curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64 | ||
| chmod +x ./kind | ||
| mv ./kind /usr/local/bin/kind | ||
|
|
||
| curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/linux/amd64 | ||
| chmod +x kubebuilder | ||
| mv kubebuilder /usr/local/bin/ | ||
|
|
||
| KUBECTL_VERSION=$(curl -L -s https://dl.k8s.io/release/stable.txt) | ||
| curl -LO "https://dl.k8s.io/release/$KUBECTL_VERSION/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| mv kubectl /usr/local/bin/kubectl | ||
|
|
||
| docker network create -d=bridge --subnet=172.19.0.0/24 kind | ||
|
|
||
| kind version | ||
| kubebuilder version | ||
| docker --version | ||
| go version | ||
| kubectl version --client |
25 changes: 25 additions & 0 deletions
25
docs/book/src/getting-started/testdata/project/.devcontainer/devcontainer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "name": "Kubebuilder DevContainer", | ||
| "image": "golang:1.22", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
|
|
||
| "runArgs": ["--network=host"], | ||
|
|
||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" | ||
| }, | ||
| "extensions": [ | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-docker" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| "onCreateCommand": "bash .devcontainer/post-install.sh" | ||
| } | ||
|
|
23 changes: 23 additions & 0 deletions
23
docs/book/src/getting-started/testdata/project/.devcontainer/post-install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/bin/bash | ||
| set -x | ||
|
|
||
| curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64 | ||
| chmod +x ./kind | ||
| mv ./kind /usr/local/bin/kind | ||
|
|
||
| curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/linux/amd64 | ||
| chmod +x kubebuilder | ||
| mv kubebuilder /usr/local/bin/ | ||
|
|
||
| KUBECTL_VERSION=$(curl -L -s https://dl.k8s.io/release/stable.txt) | ||
| curl -LO "https://dl.k8s.io/release/$KUBECTL_VERSION/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| mv kubectl /usr/local/bin/kubectl | ||
|
|
||
| docker network create -d=bridge --subnet=172.19.0.0/24 kind | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just for we have tracked at least here in a comment why it is required: |
||
|
|
||
| kind version | ||
| kubebuilder version | ||
| docker --version | ||
| go version | ||
| kubectl version --client | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
pkg/plugins/golang/v4/scaffolds/internal/templates/devcontainer.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| /* | ||
| Copyright 2024 The Kubernetes Authors. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package templates | ||
|
|
||
| import ( | ||
| "sigs.k8s.io/kubebuilder/v4/pkg/machinery" | ||
| ) | ||
|
|
||
| const devContainerTemplate = `{ | ||
| "name": "Kubebuilder DevContainer", | ||
| "image": "golang:1.22", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
|
|
||
| "runArgs": ["--network=host"], | ||
|
|
||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" | ||
| }, | ||
| "extensions": [ | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-docker" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| "onCreateCommand": "bash .devcontainer/post-install.sh" | ||
| } | ||
|
|
||
| ` | ||
|
|
||
| const postInstallScript = `#!/bin/bash | ||
| set -x | ||
|
|
||
| curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64 | ||
| chmod +x ./kind | ||
| mv ./kind /usr/local/bin/kind | ||
|
|
||
| curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/linux/amd64 | ||
| chmod +x kubebuilder | ||
| mv kubebuilder /usr/local/bin/ | ||
|
|
||
| KUBECTL_VERSION=$(curl -L -s https://dl.k8s.io/release/stable.txt) | ||
| curl -LO "https://dl.k8s.io/release/$KUBECTL_VERSION/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| mv kubectl /usr/local/bin/kubectl | ||
|
|
||
| docker network create -d=bridge --subnet=172.19.0.0/24 kind | ||
|
|
||
| kind version | ||
| kubebuilder version | ||
| docker --version | ||
| go version | ||
| kubectl version --client | ||
| ` | ||
|
|
||
| var _ machinery.Template = &DevContainer{} | ||
| var _ machinery.Template = &DevContainerPostInstallScript{} | ||
|
|
||
| // DevCotaniner scaffoldds a `devcontainer.json` configurations file for | ||
| // creating Kubebuilder & Kind based DevContainer. | ||
| type DevContainer struct { | ||
| machinery.TemplateMixin | ||
| } | ||
|
|
||
| type DevContainerPostInstallScript struct { | ||
| machinery.TemplateMixin | ||
| } | ||
|
|
||
| func (f *DevContainer) SetTemplateDefaults() error { | ||
| if f.Path == "" { | ||
| f.Path = ".devcontainer/devcontainer.json" | ||
| } | ||
|
|
||
| f.TemplateBody = devContainerTemplate | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func (f *DevContainerPostInstallScript) SetTemplateDefaults() error { | ||
| if f.Path == "" { | ||
| f.Path = ".devcontainer/post-install.sh" | ||
| } | ||
|
|
||
| f.TemplateBody = postInstallScript | ||
|
|
||
| return nil | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
testdata/project-v4-multigroup-with-deploy-image/.devcontainer/devcontainer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "name": "Kubebuilder DevContainer", | ||
| "image": "golang:1.22", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
|
|
||
| "runArgs": ["--network=host"], | ||
|
|
||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" | ||
| }, | ||
| "extensions": [ | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-docker" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| "onCreateCommand": "bash .devcontainer/post-install.sh" | ||
| } | ||
|
|
23 changes: 23 additions & 0 deletions
23
testdata/project-v4-multigroup-with-deploy-image/.devcontainer/post-install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/bin/bash | ||
| set -x | ||
|
|
||
| curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64 | ||
| chmod +x ./kind | ||
| mv ./kind /usr/local/bin/kind | ||
|
|
||
| curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/linux/amd64 | ||
| chmod +x kubebuilder | ||
| mv kubebuilder /usr/local/bin/ | ||
|
|
||
| KUBECTL_VERSION=$(curl -L -s https://dl.k8s.io/release/stable.txt) | ||
| curl -LO "https://dl.k8s.io/release/$KUBECTL_VERSION/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| mv kubectl /usr/local/bin/kubectl | ||
|
|
||
| docker network create -d=bridge --subnet=172.19.0.0/24 kind | ||
|
|
||
| kind version | ||
| kubebuilder version | ||
| docker --version | ||
| go version | ||
| kubectl version --client |
25 changes: 25 additions & 0 deletions
25
testdata/project-v4-multigroup/.devcontainer/devcontainer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "name": "Kubebuilder DevContainer", | ||
| "image": "golang:1.22", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
|
|
||
| "runArgs": ["--network=host"], | ||
|
|
||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" | ||
| }, | ||
| "extensions": [ | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-docker" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| "onCreateCommand": "bash .devcontainer/post-install.sh" | ||
| } | ||
|
|
23 changes: 23 additions & 0 deletions
23
testdata/project-v4-multigroup/.devcontainer/post-install.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| #!/bin/bash | ||
| set -x | ||
|
|
||
| curl -Lo ./kind https://kind.sigs.k8s.io/dl/latest/kind-linux-amd64 | ||
| chmod +x ./kind | ||
| mv ./kind /usr/local/bin/kind | ||
|
|
||
| curl -L -o kubebuilder https://go.kubebuilder.io/dl/latest/linux/amd64 | ||
| chmod +x kubebuilder | ||
| mv kubebuilder /usr/local/bin/ | ||
|
|
||
| KUBECTL_VERSION=$(curl -L -s https://dl.k8s.io/release/stable.txt) | ||
| curl -LO "https://dl.k8s.io/release/$KUBECTL_VERSION/bin/linux/amd64/kubectl" | ||
| chmod +x kubectl | ||
| mv kubectl /usr/local/bin/kubectl | ||
|
|
||
| docker network create -d=bridge --subnet=172.19.0.0/24 kind | ||
|
|
||
| kind version | ||
| kubebuilder version | ||
| docker --version | ||
| go version | ||
| kubectl version --client |
25 changes: 25 additions & 0 deletions
25
testdata/project-v4-with-deploy-image/.devcontainer/devcontainer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "name": "Kubebuilder DevContainer", | ||
| "image": "golang:1.22", | ||
| "features": { | ||
| "ghcr.io/devcontainers/features/docker-in-docker:2": {}, | ||
| "ghcr.io/devcontainers/features/git:1": {} | ||
| }, | ||
|
|
||
| "runArgs": ["--network=host"], | ||
|
|
||
| "customizations": { | ||
| "vscode": { | ||
| "settings": { | ||
| "terminal.integrated.shell.linux": "/bin/bash" | ||
| }, | ||
| "extensions": [ | ||
| "ms-kubernetes-tools.vscode-kubernetes-tools", | ||
| "ms-azuretools.vscode-docker" | ||
| ] | ||
| } | ||
| }, | ||
|
|
||
| "onCreateCommand": "bash .devcontainer/post-install.sh" | ||
| } | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.