Skip to content

Commit 9d3caa3

Browse files
authored
publish-on-change workflow should use helm client login instead of docker login (#264)
fixes: https://github.com/kubernetes-sigs/inference-perf/actions/runs/18889068464/job/54103290056
1 parent 5837ed1 commit 9d3caa3

File tree

2 files changed

+15
-17
lines changed

2 files changed

+15
-17
lines changed

.github/workflows/publish-on-change.yml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -103,15 +103,11 @@ jobs:
103103
--version $CHART_VERSION \
104104
--app-version $APP_VERSION
105105
106-
- name: Login to Quay.io
107-
uses: docker/login-action@v3
108-
with:
109-
registry: quay.io
110-
username: ${{ secrets.QUAY_USERNAME }}
111-
password: ${{ secrets.QUAY_PASSWORD }}
112-
113106
- name: Push Helm chart to OCI registry
114107
run: |
108+
# Login to Quay.io Helm registry
109+
echo "${{ secrets.QUAY_PASSWORD }}" | helm registry login quay.io -u "${{ secrets.QUAY_USERNAME }}" --password-stdin
110+
115111
OCI_BASE_URL="oci://quay.io/inference-perf/charts"
116112
OCI_CHART_REPO="oci://quay.io/inference-perf/charts/inference-perf"
117113
CHART_VERSION="${{ needs.docker.outputs.chart_version }}"

.github/workflows/publish-on-release.yml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -156,15 +156,17 @@ jobs:
156156
CHART_VERSION=${GITHUB_REF#refs/tags/v}
157157
helm package deploy/inference-perf -d helm-releases --version $CHART_VERSION --app-version ${{ env.RELEASE_VERSION }}
158158
159-
- name: Login to Quay.io
160-
uses: docker/login-action@v3
161-
with:
162-
registry: quay.io
163-
username: ${{ secrets.QUAY_USERNAME }}
164-
password: ${{ secrets.QUAY_PASSWORD }}
165-
166159
- name: Push Helm chart to OCI registry
167160
run: |
168-
# Remove 'v' prefix from version
169-
CHART_VERSION=${GITHUB_REF#refs/tags/v}
170-
helm push helm-releases/inference-perf-${CHART_VERSION}.tgz oci://quay.io/inference-perf/charts
161+
# Login to Quay.io Helm registry
162+
echo "${{ secrets.QUAY_PASSWORD }}" | helm registry login quay.io -u "${{ secrets.QUAY_USERNAME }}" --password-stdin
163+
164+
OCI_BASE_URL="oci://quay.io/inference-perf/charts"
165+
OCI_CHART_REPO="oci://quay.io/inference-perf/charts/inference-perf"
166+
CHART_VERSION=${GITHUB_REF#refs/tags/v} # Remove 'v' prefix from version
167+
168+
echo "Pushing Helm chart ${CHART_VERSION} to ${OCI_BASE_URL}"
169+
helm push helm-releases/inference-perf-${CHART_VERSION}.tgz ${OCI_BASE_URL}
170+
171+
echo "Tagging Helm chart ${CHART_VERSION} as latest..."
172+
helm registry copy "${OCI_CHART_REPO}:${CHART_VERSION}" "${OCI_CHART_REPO}:latest"

0 commit comments

Comments
 (0)