Skip to content

chore(deps): bump github.com/prometheus/common from 0.65.0 to 0.66.1 #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

chore(deps): bump github.com/prometheus/common from 0.65.0 to 0.66.1 #1546

wants to merge 1 commit into from

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 8, 2025

Bumps github.com/prometheus/common from 0.65.0 to 0.66.1.

Release notes

Sourced from github.com/prometheus/common's releases.

v0.66.1

This release has no functional changes, it just drops the dependencies github.com/grafana/regexp and go.uber.org/atomic and replaces gopkg.in/yaml.v2 with go.yaml.in/yaml/v2 (a drop-in replacement).

What's Changed

Full Changelog: prometheus/common@v1.20.99...v0.66.1

v0.66.0

⚠️ Breaking Changes ⚠️

  • A default-constructed TextParser will be invalid. It must have a valid scheme set, so users should use the NewTextParser function to create a valid TextParser. Otherwise parsing will panic with "Invalid name validation scheme requested: unset".

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from github.com/prometheus/common's changelog.

v0.66.1 / 2025-09-05

This release has no functional changes, it just drops the dependencies github.com/grafana/regexp and go.uber.org/atomic and replaces gopkg.in/yaml.v2 with go.yaml.in/yaml/v2 (a drop-in replacement).

What's Changed

Full Changelog: prometheus/common@v1.20.99...v0.66.1

v0.66.0 / 2025-09-02

⚠️ Breaking Changes ⚠️

  • A default-constructed TextParser will be invalid. It must have a valid scheme set, so users should use the NewTextParser function to create a valid TextParser. Otherwise parsing will panic with "Invalid name validation scheme requested: unset".

What's Changed

New Contributors

... (truncated)

Commits
  • 8975dde Revert "Use go.uber.org/atomic instead of sync/atomic (#825)" (#838)
  • 08d7f66 Move to supported version of yaml parser (#834)
  • 80e275e Revert "Use github.com/grafana/regexp instead of regexp" (#835)
  • 4c2f9e7 Merge pull request #832 from roidelapluie/retract
  • e120453 Retract v1.20.3
  • 2b1487c Merge pull request #827 from prometheus/dependabot/go_modules/github.com/stre...
  • db38951 Merge pull request #829 from prometheus/dependabot/go_modules/golang.org/x/ne...
  • 9e19a90 build(deps): bump github.com/stretchr/testify from 1.10.0 to 1.11.1
  • a1ba2a7 build(deps): bump golang.org/x/net from 0.42.0 to 0.43.0
  • c7a031c Merge pull request #830 from prometheus/dependabot/go_modules/google.golang.o...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
chore(deps): bump github.com/prometheus/common from 0.65.0 to 0.66.1
15f0c93 
Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.65.0 to 0.66.1.
- [Release notes](https://github.com/prometheus/common/releases)
- [Changelog](https://github.com/prometheus/common/blob/main/CHANGELOG.md)
- [Commits](prometheus/common@v0.65.0...v0.66.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/common
  dependency-version: 0.66.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. labels Sep 8, 2025
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
Once this PR has been reviewed and has the lgtm label, please assign nirrozenbaum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 8, 2025

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 8, 2025
@netlify
Copy link

netlify bot commented Sep 8, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 15f0c93
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68bf49c52e0d5d0008b4f77d
😎 Deploy Preview https://deploy-preview-1546--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 12, 2025

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 12, 2025

@dependabot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-test-e2e-main 15f0c93 link true /test pull-gateway-api-inference-extension-test-e2e-main
pull-gateway-api-inference-extension-test-unit-main 15f0c93 link true /test pull-gateway-api-inference-extension-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 12, 2025

@JeffLuoo can you please take a look, this update seems to be breaking something in our code

@JeffLuoo JeffLuoo mentioned this pull request Sep 12, 2025
Merged
@JeffLuoo
Copy link
Contributor

JeffLuoo commented Sep 12, 2025

Manually build EPP with the version bump and it crashed:

panic: Invalid name validation scheme requested: unset

goroutine 273 [running]:
github.com/prometheus/common/model.ValidationScheme.IsValidMetricName(0x52a605?, {0xc000808b40?, 0x21?})
        /go/pkg/mod/github.com/prometheus/[email protected]/model/metric.go:179 +0xb9
github.com/prometheus/common/expfmt.(*TextParser).setOrCreateCurrentMF(0xc000448780)
        /go/pkg/mod/github.com/prometheus/[email protected]/expfmt/text_parse.go:836 +0x85
github.com/prometheus/common/expfmt.(*TextParser).startComment(0xc000448780)
        /go/pkg/mod/github.com/prometheus/[email protected]/expfmt/text_parse.go:227 +0x15c
github.com/prometheus/common/expfmt.(*TextParser).TextToMetricFamilies(0xc000448780, {0x2780480?, 0xc000764540?})
        /go/pkg/mod/github.com/prometheus/[email protected]/expfmt/text_parse.go:116 +0x5f
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend/metrics.(*PodMetricsClientImpl).FetchMetrics(0xc00014ae40, {0x27aacb8, 0xc0002f29a0}, 0xc000d12080, 0xc0002862d0, 0x880400?)
        /src/pkg/epp/backend/metrics/metrics.go:69 +0x326
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend/metrics.(*podMetrics).refreshMetrics(0xc0002f2770)
        /src/pkg/epp/backend/metrics/pod_metrics.go:123 +0xda
sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend/metrics.(*podMetrics).startRefreshLoop.func1.1()
        /src/pkg/epp/backend/metrics/pod_metrics.go:103 +0x216
created by sigs.k8s.io/gateway-api-inference-extension/pkg/epp/backend/metrics.(*podMetrics).startRefreshLoop.func1 in goroutine 175
        /src/pkg/epp/backend/metrics/pod_metrics.go:92 +0x85

which is the root cause of failing test. #1580 for bumping it manually.

@ahg-g
Copy link
Contributor

ahg-g commented Sep 12, 2025

Addressed by #1580

@ahg-g ahg-g closed this Sep 12, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 12, 2025

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/prometheus/common-0.66.1 branch September 12, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahg-g ahg-g Awaiting requested review from ahg-g

@danehans danehans Awaiting requested review from danehans

Assignees

No one assigned

Labels

area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k8s-ci-robot @ahg-g @JeffLuoo