From 51487c92b0de8ee0d74ae0d18445e3825f2f4b2e Mon Sep 17 00:00:00 2001 From: Vince Prignano Date: Thu, 23 Jul 2020 08:06:45 -0700 Subject: [PATCH] Mark leak goroutine tests as pending Signed-off-by: Vince Prignano --- pkg/controller/controller_test.go | 4 +++- pkg/manager/manager_test.go | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/controller/controller_test.go b/pkg/controller/controller_test.go index 2194220e31..ff580fbfc3 100644 --- a/pkg/controller/controller_test.go +++ b/pkg/controller/controller_test.go @@ -93,7 +93,9 @@ var _ = Describe("controller.Controller", func() { close(done) }) - It("should not leak goroutines when stop", func(done Done) { + // This test has been marked as pending because it has been causing lots of flakes in CI. + // It should be rewritten at some point later in the future. + XIt("should not leak goroutines when stop", func(done Done) { // TODO(directxman12): After closing the proper leaks on watch this must be reduced to 0 // The leaks currently come from the event-related code (as in corev1.Event). threshold := 3 diff --git a/pkg/manager/manager_test.go b/pkg/manager/manager_test.go index f09d206745..d8191334fa 100644 --- a/pkg/manager/manager_test.go +++ b/pkg/manager/manager_test.go @@ -1168,7 +1168,9 @@ var _ = Describe("manger.Manager", func() { }) }) - It("should not leak goroutines when stop", func(done Done) { + // This test has been marked as pending because it has been causing lots of flakes in CI. + // It should be rewritten at some point later in the future. + XIt("should not leak goroutines when stop", func(done Done) { // TODO(directxman12): After closing the proper leaks on watch this must be reduced to 0 // The leaks currently come from the event-related code (as in corev1.Event). threshold := 3