📖 Add documentation on how to support multi-tenancy with webhooks #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
requested review from
CecileRobertMichon,
alexeldeib,
dlipovetsky,
jichenjc,
justinsb,
randomvariable,
wfernandes and
yastij
k8s-ci-robot
added
cncf-cla: yes
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Member
Author
|
/this-is-fine |
Contributor
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Member
|
/retest |
Member
|
LGTM to me |
yastij
reviewed
Feb 14, 2020
Member
yastij
left a comment
yastij
left a comment
There was a problem hiding this comment.
/lgtm
/hold
holding for other reviewers
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
vincepri
force-pushed
the
add-docs-tenancy
branch
from
edbfbbd to
379a34a
Compare
k8s-ci-robot
removed
the
lgtm
vincepri
force-pushed
the
add-docs-tenancy
branch
from
379a34a to
b47e2a8
Compare
detiber
reviewed
Feb 14, 2020
| - **Create** | ||
| - **kustomization.yaml**: This file is going to function as the new entrypoint to run `kustomize build`. | ||
| `PROVIDER_NAME` is the name of your provider, e.g. `aws`. | ||
| `PROVIDER_NAME` is the type of your provider, e.g. `control-plane`, `bootstrap, `infrastructure`. |
Contributor
There was a problem hiding this comment.
Suggested change
| `PROVIDER_NAME` is the type of your provider, e.g. `control-plane`, `bootstrap, `infrastructure`. | |
| `PROVIDER_TYPE` is the type of your provider, e.g. `control-plane`, `bootstrap`, `infrastructure`. |
vincepri
force-pushed
the
add-docs-tenancy
branch
from
b47e2a8 to
7251a8e
Compare
detiber
reviewed
Feb 14, 2020
| - **Create** | ||
| - **kustomization.yaml**: This file is going to function as the new entrypoint to run `kustomize build`. | ||
| `PROVIDER_NAME` is the name of your provider, e.g. `aws`. | ||
| `PROVIDER_NAME` is the type of your provider, e.g. `control-plane`, `bootstrap`, `infrastructure`. |
Contributor
There was a problem hiding this comment.
Suggested change
| `PROVIDER_NAME` is the type of your provider, e.g. `control-plane`, `bootstrap`, `infrastructure`. | |
| `PROVIDER_TYPE` is the type of your provider, e.g. `control-plane`, `bootstrap`, `infrastructure`. |
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
add-docs-tenancy
branch
from
7251a8e to
bfd4873
Compare
Contributor
|
/lgtm |
k8s-ci-robot
added
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
/assign @ncdc @detiber @fabriziopandini
/cc @yastij @CecileRobertMichon @alexeldeib @justinsb @wfernandes @dlipovetsky @randomvariable @jichenjc