-
Notifications
You must be signed in to change notification settings - Fork 284
Use go modules #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use go modules #411
Conversation
|
I referred to kubernetes-sigs/cluster-api-provider-azure#231. |
| k8s.io/gengo v0.0.0-20190327210449-e17681d19d3a // indirect | ||
| k8s.io/klog v0.3.3 | ||
| k8s.io/kube-openapi v0.0.0-20190603182131-db7b694dc208 // indirect | ||
| sigs.k8s.io/cluster-api v0.1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previously it's branch release-0.1 now it's a tag ? just want to make sure understand is correct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, The go.mod file generally use semantics versions which is introduced by tagging a revision in the underlying source repository.
https://golang.org/cmd/go/#hdr-Pseudo_versions
|
/approve @sbueringer do you need this to be merged after #382 ? |
|
I ran locally and able to create a cluster |
|
run this locally for 'make test' and saw additional changes like following, I guess you might need commit this? |
|
/approve cancel |
@jichenjc I resolved conflict. check again, please. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hidekazuna, jichenjc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #381
Special notes for your reviewer:
Release note: