Skip to content

Conversation

@hidekazuna
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #381

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 26, 2019
@hidekazuna hidekazuna changed the title Use go modules [WIP] Use go modules Jul 26, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2019
@hidekazuna hidekazuna changed the title [WIP] Use go modules Use go modules Jul 29, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2019
@hidekazuna
Copy link
Contributor Author

hidekazuna commented Jul 29, 2019

I referred to kubernetes-sigs/cluster-api-provider-azure#231.

k8s.io/gengo v0.0.0-20190327210449-e17681d19d3a // indirect
k8s.io/klog v0.3.3
k8s.io/kube-openapi v0.0.0-20190603182131-db7b694dc208 // indirect
sigs.k8s.io/cluster-api v0.1.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previously it's branch release-0.1 now it's a tag ? just want to make sure understand is correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, The go.mod file generally use semantics versions which is introduced by tagging a revision in the underlying source repository.
https://golang.org/cmd/go/#hdr-Pseudo_versions

@hidekazuna hidekazuna mentioned this pull request Jul 30, 2019
@jichenjc
Copy link
Contributor

jichenjc commented Aug 1, 2019

/approve

@sbueringer do you need this to be merged after #382 ?

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@jichenjc
Copy link
Contributor

jichenjc commented Aug 1, 2019

I ran locally and able to create a cluster

@sbueringer
Copy link
Member

@jichenjc if it's okay let's merge #401 then go modules. But I think we have consensus to merge the LB PR now so you can merge both now

@jichenjc
Copy link
Contributor

jichenjc commented Aug 1, 2019

@hidekazuna

run this locally for 'make test' and saw additional changes like following, I guess you might need commit this?

+++ b/config/crds/openstackproviderconfig_v1alpha1_openstackclusterproviderspec.yaml
@@ -87,6 +87,10 @@ spec:
                       ipVersion:
                         format: int64
                         type: integer
+                      ipv6AddressMode:
+                        type: string
+                      ipv6RaMode:
+                        type: string
                       limit:
                         format: int64
                         type: integer
diff --git a/vendor/sigs.k8s.io/cluster-api/BUILD.bazel b/vendor/sigs.k8s.io/cluster-api/BUILD.bazel
deleted file mode 100644
index be252e22..00000000
--- a/vendor/sigs.k8s.io/cluster-api/BUILD.bazel
+++ /dev/null
@@ -1,21 +0,0 @@
-load("@bazel_gazelle//:def.bzl", "gazelle")
-load("//build:run_in_workspace_with_goroot.bzl", "workspace_binary")
-
-# gazelle:prefix sigs.k8s.io/cluster-api
-# gazelle:proto disable_global
-gazelle(
-    name = "gazelle",
-    external = "vendored",
-)
-
-workspace_binary(
-    name = "lint",
-    args = ["run"],
-    cmd = "@com_github_golangci_golangci-lint//cmd/golangci-lint",
-)
-

@jichenjc
Copy link
Contributor

jichenjc commented Aug 1, 2019

/approve cancel

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@hidekazuna
Copy link
Contributor Author

@hidekazuna

run this locally for 'make test' and saw additional changes like following, I guess you might need commit this?

@jichenjc I resolved conflict. check again, please.

@jichenjc
Copy link
Contributor

jichenjc commented Aug 1, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hidekazuna, jichenjc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 09ca2e8 into kubernetes-sigs:master Aug 1, 2019
@hidekazuna hidekazuna deleted the go_module branch August 2, 2019 07:54
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use go modules

4 participants