Add support for multiple kubeconfigs in the KUBECONFIG env var. #267
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
| }); | ||
| }); | ||
|
|
||
| describe('load from multi $KUBECONFIG', () => { |
There was a problem hiding this comment.
@brendanburns as you mentioned the error handling/semantics of this are a bit vague.
I think maybe we should add a few tests for errors here so when we eventually fix bugs/change things we can be sure not to change unintended side effects
- Duplicate context's
- Duplicate users's
- Duplicate clusters's
- Requiring all the config files are in the same root directory (why is this even a thing?)
I guess as a side effect we add tests for the public API's we are adding, requiring
testdata/kubeconfig-2.yaml
Outdated
| - name: userC | ||
| user: | ||
| username: foo | ||
| password: bar No newline at end of file |
There was a problem hiding this comment.
Missing newline at end of the file.
|
Sorry for the delay it appears like github didn't submit my review. |
k8s-ci-robot
added
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
Comments addressed. |
|
/lgtm I am not sure if we should wait to stabilize the refactorings or push a release with this. (it feels like this is a much-requested feature and it might be good to get feedback? |
k8s-ci-robot
added
the
lgtm
3 participants
@drubin
Closes #265