clean up and add testcases for less sensitive config loader

Author: tg123

src/KubernetesClientConfiguration.ConfigFile.cs

@@ -51,12 +51,25 @@ public static KubernetesClientConfiguration BuildConfigFromConfigFile(FileInfo k
 
             var k8SConfig = LoadKubeConfig(kubeconfig);
             var k8SConfiguration = new KubernetesClientConfiguration();
-            k8SConfiguration.Initialize(k8SConfig, currentContext);
+
+            currentContext = currentContext ?? k8SConfig.CurrentContext;
+
+            // only init context if context if set
+            if (currentContext != null)
+            {
+                k8SConfiguration.InitializeContext(k8SConfig, currentContext);
+            }
 
             if (!string.IsNullOrWhiteSpace(masterUrl))
             {
                 k8SConfiguration.Host = masterUrl;
             }
+
+            if (string.IsNullOrWhiteSpace(k8SConfiguration.Host))
+            {
+                throw new KubeConfigException("Cannot infer server host url either from context or masterUrl");
+            }
+
             return k8SConfiguration;
         }
 
@@ -65,11 +78,9 @@ public static KubernetesClientConfiguration BuildConfigFromConfigFile(FileInfo k
         /// </summary>
         /// <param name="k8SConfig">Kubernetes Configuration</param>
         /// <param name="currentContext">Current Context</param>
-        private void Initialize(K8SConfiguration k8SConfig, string currentContext = null)
+        private void InitializeContext(K8SConfiguration k8SConfig, string currentContext)
         {
             // current context
-            currentContext = currentContext ?? k8SConfig.CurrentContext;
-
             var activeContext =
                 k8SConfig.Contexts.FirstOrDefault(
                     c => c.Name.Equals(currentContext, StringComparison.OrdinalIgnoreCase));

tests/KubernetesClientConfigurationTests.cs

@@ -0,0 +1,19 @@
+---
+apiVersion: v1
+clusters:
+- cluster:
+    certificate-authority: assets/ca.crt
+    server: https://horse.org:4443
+  name: horse-cluster
+contexts:
+- context:
+    cluster: horse-cluster
+    namespace: chisel-ns
+    user: green-user
+  name: federal-context
+kind: Config
+users:
+- name: green-user
+  user:
+    password: secret
+    username: admin

tests/assets/kubeconfig-no-context.yml renamed to tests/assets/kubeconfig.no-context.yml

@@ -0,0 +1,14 @@
+---
+current-context: federal-context
+apiVersion: v1
+clusters:
+- cluster:
+    certificate-authority: assets/ca.crt
+    server: https://horse.org:4443
+  name: horse-cluster
+contexts:
+- context:
+    cluster: horse-cluster
+    namespace: chisel-ns
+  name: federal-context
+kind: Config

tests/assets/kubeconfig.no-current-context.yml

@@ -0,0 +1,19 @@
+---
+current-context: federal-context
+apiVersion: v1
+clusters:
+- cluster:
+    server: http://horse.org
+  name: horse-cluster
+contexts:
+- context:
+    cluster: horse-cluster
+    namespace: chisel-ns
+    user: green-user
+  name: federal-context
+kind: Config
+users:
+- name: green-user
+  user:
+    password: secret
+    username: admin

tests/assets/kubeconfig.no-user.yml

@@ -0,0 +1,15 @@
+---
+current-context: federal-context
+apiVersion: v1
+clusters:
+- cluster:
+    certificate-authority: assets/ca.crt
+    server: https://horse.org:4443
+  name: horse-cluster
+contexts:
+- context:
+    cluster: horse-cluster
+    namespace: chisel-ns
+    user: green-user
+  name: federal-context
+kind: Config