fix(web): address-coderabbit-feedback

Author: tractorss

web/src/layout/Header/navbar/Menu/Settings/Notifications/FormContactDetails/FormContact.tsx

@@ -48,7 +48,7 @@ const FormContact: React.FC<IForm> = ({
   };
 
   const fieldVariant = useMemo(() => {
-    if (isEmpty(contactInput) || !isEditing) {
+    if (!isEditing || isEmpty(contactInput)) {
       return undefined;
     }
     return contactIsValid ? "success" : "error";

web/src/pages/Cases/CaseDetails/Evidence/SubmitEvidenceModal.tsx

@@ -14,7 +14,7 @@ import { wrapWithToast, OPTIONS as toastOptions } from "utils/wrapWithToast";
 
 import EnsureAuth from "components/EnsureAuth";
 import { EnsureChain } from "components/EnsureChain";
-import { isEmpty, isUndefined } from "src/utils";
+import { isEmpty } from "src/utils";
 
 const StyledModal = styled(Modal)`
   position: absolute;
@@ -65,7 +65,7 @@ const SubmitEvidenceModal: React.FC<{
   const [file, setFile] = useState<File>();
   const { uploadFile } = useAtlasProvider();
 
-  const isDisabled = useMemo(() => isSending || isEmpty(message) || isUndefined(message), [isSending, message]);
+  const isDisabled = useMemo(() => isSending || isEmpty(message), [isSending, message]);
 
   const submitEvidence = useCallback(async () => {
     try {

web/src/pages/Resolver/NavigationButtons/NextButton.tsx

@@ -22,17 +22,17 @@ const NextButton: React.FC<INextButton> = ({ nextRoute }) => {
     disputeData.answers.every((answer) => answer.title !== "" && answer.description !== "");
 
   //check if any filled address or ens is invalid
-  const areFilledAddressesValid = disputeData?.aliasesArray?.every((alias) =>
-    isEmpty(alias.address) && isEmpty(alias.name) ? true : alias.isValid
-  );
-
+  const areAliasesValidOrEmpty = disputeData?.aliasesArray?.every((alias) => {
+    const isAliasEmpty = isEmpty(alias.address) && isEmpty(alias.name);
+    return isAliasEmpty || alias.isValid;
+  });
   const isButtonDisabled =
     (location.pathname.includes("/resolver/title") && !disputeData.title) ||
     (location.pathname.includes("/resolver/description") && !disputeData.description) ||
     (location.pathname.includes("/resolver/court") && !disputeData.courtId) ||
     (location.pathname.includes("/resolver/jurors") && !disputeData.arbitrationCost) ||
     (location.pathname.includes("/resolver/voting-options") && !areVotingOptionsFilled) ||
-    (location.pathname.includes("/resolver/notable-persons") && !areFilledAddressesValid) ||
+    (location.pathname.includes("/resolver/notable-persons") && !areAliasesValidOrEmpty) ||
     (location.pathname.includes("/resolver/policy") && (isPolicyUploading || !disputeData.policyURI));
 
   return <Button disabled={isButtonDisabled} onClick={() => navigate(nextRoute)} text="Next" />;