chore: rng testcases

Author: Anmol-Dhiman

contracts/deploy/03-vea-mock.ts

@@ -56,7 +56,7 @@ const deployHomeGateway: DeployFunction = async (hre: HardhatRuntimeEnvironment)
 
   // TODO: disable the gateway until fully initialized with the correct fees OR allow disputeCreators to add funds again if necessary.
   const signer = (await hre.ethers.getSigners())[0];
-  const core = await KlerosCore__factory.connect(klerosCore.address, signer);
+  const core = KlerosCore__factory.connect(klerosCore.address, signer);
   // TODO: set up the correct fees for the FORKING_COURT
   const fee = (await core.courts(Courts.GENERAL)).feeForJuror;
   await execute("ForeignGatewayOnEthereum", { from: deployer, log: true }, "changeCourtJurorFee", Courts.GENERAL, fee);

contracts/scripts/keeperBot.ts

@@ -484,7 +484,10 @@ async function main() {
   if (!disputes) {
     return;
   }
+
   let disputesWithoutJurors = await filterAsync(disputes, async (dispute) => {
+    console.log(dispute.id);
+    console.log(dispute.currentRoundIndex);
     return !(await isDisputeFullyDrawn(dispute));
   });
 

contracts/test/rng/index.ts

@@ -1,47 +1,46 @@
 import { expect } from "chai";
 import { ethers, network } from "hardhat";
-import { BigNumber } from "ethers";
+import { toBigInt } from "ethers";
 import { IncrementalNG, BlockHashRNG } from "../../typechain-types";
 
 let rng, rngFactory;
 const initialNg = 424242;
+const abiCoder = ethers.AbiCoder.defaultAbiCoder();
 
 describe("IncrementalNG", async () => {
   beforeEach("Setup", async () => {
     rngFactory = await ethers.getContractFactory("IncrementalNG");
     rng = (await rngFactory.deploy(initialNg)) as IncrementalNG;
-    await rng.deployed();
   });
 
   it("Should return a number incrementing each time", async () => {
-    expect(await rng.callStatic.receiveRandomness(689376)).to.equal(initialNg);
+    expect(await rng.receiveRandomness.staticCall(689376)).to.equal(initialNg);
     await rng.receiveRandomness(29543);
-    expect(await rng.callStatic.receiveRandomness(5894382)).to.equal(initialNg + 1);
+    expect(await rng.receiveRandomness.staticCall(5894382)).to.equal(initialNg + 1);
     await rng.receiveRandomness(0);
-    expect(await rng.callStatic.receiveRandomness(3465)).to.equal(initialNg + 2);
-    await rng.receiveRandomness(BigNumber.from(2).pow(255));
-    expect(await rng.callStatic.receiveRandomness(0)).to.equal(initialNg + 3);
+    expect(await rng.receiveRandomness.staticCall(3465)).to.equal(initialNg + 2);
+    await rng.receiveRandomness(toBigInt(2) ** toBigInt(255));
+    expect(await rng.receiveRandomness.staticCall(0)).to.equal(initialNg + 3);
   });
 });
 
 describe("BlockHashRNG", async () => {
   beforeEach("Setup", async () => {
     rngFactory = await ethers.getContractFactory("BlockHashRNG");
     rng = (await rngFactory.deploy()) as BlockHashRNG;
-    await rng.deployed();
   });
 
   it("Should return a non-zero number for a block number in the past", async () => {
     const tx = await rng.receiveRandomness(9876543210);
     const trace = await network.provider.send("debug_traceTransaction", [tx.hash]);
-    const [rn] = ethers.utils.defaultAbiCoder.decode(["uint"], `0x${trace.returnValue}`);
+    const [rn] = abiCoder.decode(["uint"], `0x${trace.returnValue}`);
     expect(rn).to.equal(0);
   });
 
   it("Should return zero for a block number in the future", async () => {
     const tx = await rng.receiveRandomness(5);
     const trace = await network.provider.send("debug_traceTransaction", [tx.hash]);
-    const [rn] = ethers.utils.defaultAbiCoder.decode(["uint"], `0x${trace.returnValue}`);
+    const [rn] = abiCoder.decode(["uint"], `0x${trace.returnValue}`);
     expect(rn).to.not.equal(0);
   });
 });