Skip to content

fix: disable button when user has insufficient native balance #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d94be62
fix: disable button when user has insufficient native balance
ShubhamParkhi Sep 24, 2024
84605c6
fix(web): deposit payment button
ShubhamParkhi Sep 27, 2024
1a8d66e
fix: style error message
ShubhamParkhi Sep 29, 2024
2e8d91f
fix: styling for error message
ShubhamParkhi Sep 29, 2024
3898aeb
fix: few crashes bug fixes
kemuru Sep 30, 2024
f62a9eb
fix: style font size smaller, optimize variable calculations
kemuru Sep 30, 2024
22dec65
fix(web): Disable hooks when insufficient balance
ShubhamParkhi Sep 30, 2024
edf59af
fix(web): fix ternary operator
ShubhamParkhi Oct 1, 2024
9cf69fe
fix(web): fix insufficient balance check
ShubhamParkhi Oct 1, 2024
b1fee53
refactor(web): useReadContract hook from wagmi
ShubhamParkhi Oct 1, 2024
445b94c
fix(web): use loading and error states from hook
ShubhamParkhi Oct 2, 2024
2ee9148
fix(web): useReadContract from wagmi
ShubhamParkhi Oct 2, 2024
d603393
fix(web): use correct hooks for balance fetching
ShubhamParkhi Oct 2, 2024
7278c84
fix(web): fix raise dispute button
ShubhamParkhi Oct 2, 2024
54c1899
fix(web): better calculation for insufficient balance
ShubhamParkhi Oct 2, 2024
2159c83
fix: extra insufficient balance condition so the buttons gives feedba…
kemuru Oct 3, 2024
fed59d2
fix(web): fix token selector
ShubhamParkhi Oct 3, 2024
046b996
fix(web): Balance fetching
ShubhamParkhi Oct 4, 2024
1fe0f55
fix(web): cleaner code
ShubhamParkhi Oct 7, 2024
6271ea6
fix: nitpick
ShubhamParkhi Oct 7, 2024
964eac7
feat: add enable conditions to the usebalance and usereadcontract hooks
kemuru Oct 8, 2024
a911019
fix(web): nitpick
ShubhamParkhi Oct 8, 2024
caa750e
fix(web): nitpick
ShubhamParkhi Oct 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const FeeRequired: React.FC<IFeeRequired> = ({ arbitrationCost }) => {
return (
<StyledCard>
<StyledHeader>Arbitration fee required</StyledHeader>
<StyledQuantity>{formatEther(arbitrationCost)} ETH</StyledQuantity>
{arbitrationCost ? <StyledQuantity>{formatEther(arbitrationCost)} ETH</StyledQuantity> : null}
</StyledCard>
);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const AcceptButton: React.FC = () => {
const { id } = useTransactionDetailsContext();
const refetchQuery = useQueryRefetch();

const { data: acceptSettlementConfig } = useSimulateEscrowUniversalAcceptSettlement({
const { data: acceptSettlementConfig, isLoading, isError } = useSimulateEscrowUniversalAcceptSettlement({
args: [BigInt(id)],
});

Expand All @@ -39,7 +39,14 @@ const AcceptButton: React.FC = () => {
}
};

return <Button isLoading={isSending} disabled={isSending} text="Accept" onClick={handleAcceptSettlement} />;
return (
<Button
isLoading={isSending || isLoading}
disabled={isSending || isLoading || isError}
text="Accept"
onClick={handleAcceptSettlement}
/>
);
};

export default AcceptButton;
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ExecuteTransactionButton: React.FC = () => {
const { id } = useTransactionDetailsContext();
const refetchQuery = useQueryRefetch();

const { data: executeTransactionConfig } = useSimulateEscrowUniversalExecuteTransaction({
const { data: executeTransactionConfig, isLoading, isError } = useSimulateEscrowUniversalExecuteTransaction({
args: [BigInt(id)],
});

Expand All @@ -41,7 +41,12 @@ const ExecuteTransactionButton: React.FC = () => {
};

return (
<Button isLoading={isSending} disabled={isSending} text="Execute Transaction" onClick={handleExecuteTransaction} />
<Button
isLoading={isSending || isLoading}
disabled={isSending || isLoading || isError}
text="Execute Transaction"
onClick={handleExecuteTransaction}
/>
);
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const ProposeSettlementButton: React.FC<IProposeSettlementButton> = ({
const { id } = useTransactionDetailsContext();
const refetchQuery = useQueryRefetch();

const { data: proposeSettlementConfig } = useSimulateEscrowUniversalProposeSettlement({
const { data: proposeSettlementConfig, isLoading, isError } = useSimulateEscrowUniversalProposeSettlement({
args: [BigInt(id), parseEther(amountProposed)],
});

Expand All @@ -56,9 +56,9 @@ const ProposeSettlementButton: React.FC<IProposeSettlementButton> = ({

return (
<Button
isLoading={isSending}
disabled={isSending || !isAmountValid}
text={buttonText}
isLoading={isSending || isLoading}
disabled={isSending || !isAmountValid || isLoading || isError}
text={buttonText}
onClick={handleProposeSettlement}
/>
);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, { useMemo, useState } from "react";
import { Button } from "@kleros/ui-components-library";
import { useAccount, usePublicClient } from "wagmi";
import { useAccount, useBalance, usePublicClient } from "wagmi";
import {
useWriteEscrowUniversalPayArbitrationFeeByBuyer,
useWriteEscrowUniversalPayArbitrationFeeBySeller,
Expand All @@ -11,6 +11,8 @@ import { isUndefined } from "utils/index";
import { wrapWithToast } from "utils/wrapWithToast";
import { useTransactionDetailsContext } from "context/TransactionDetailsContext";
import { useQueryRefetch } from "hooks/useQueryRefetch";
import ClosedCircleIcon from "components/StyledIcons/ClosedCircleIcon";
import { ErrorButtonMessage } from "pages/NewTransaction/NavigationButtons/DepositPaymentButton";

interface IRaiseDisputeButton {
toggleModal?: () => void;
Expand All @@ -26,12 +28,34 @@ const RaiseDisputeButton: React.FC<IRaiseDisputeButton> = ({ toggleModal, button
const isBuyer = useMemo(() => address?.toLowerCase() === buyer?.toLowerCase(), [address, buyer]);
const refetchQuery = useQueryRefetch();

const { data: payArbitrationFeeByBuyerConfig } = useSimulateEscrowUniversalPayArbitrationFeeByBuyer({
const { data: balanceData } = useBalance({
address: address as `0x${string}` | undefined,
});

const insufficientBalance = useMemo(() => {
return balanceData && BigInt(arbitrationCost.toString()) > BigInt(balanceData.value.toString());
}, [arbitrationCost, balanceData]);

const {
data: payArbitrationFeeByBuyerConfig,
isLoading: isLoadingBuyerConfig,
isError: isErrorBuyerConfig,
} = useSimulateEscrowUniversalPayArbitrationFeeByBuyer({
query: {
enabled: isBuyer && !insufficientBalance,
},
args: [BigInt(id)],
value: arbitrationCost,
});

const { data: payArbitrationFeeBySellerConfig } = useSimulateEscrowUniversalPayArbitrationFeeBySeller({
const {
data: payArbitrationFeeBySellerConfig,
isLoading: isLoadingSellerConfig,
isError: isErrorSellerConfig,
} = useSimulateEscrowUniversalPayArbitrationFeeBySeller({
query: {
enabled: !isBuyer && !insufficientBalance,
},
args: [BigInt(id)],
value: arbitrationCost,
});
Expand Down Expand Up @@ -76,7 +100,28 @@ const RaiseDisputeButton: React.FC<IRaiseDisputeButton> = ({ toggleModal, button
}
};

return <Button isLoading={isSending} disabled={isSending} text={buttonText} onClick={handleRaiseDispute} />;
return (
<div>
<Button
isLoading={!insufficientBalance && (isSending || isLoadingBuyerConfig || isLoadingSellerConfig)}
disabled={
isSending ||
insufficientBalance ||
isLoadingBuyerConfig ||
isLoadingSellerConfig ||
isErrorBuyerConfig ||
isErrorSellerConfig
}
text={buttonText}
onClick={handleRaiseDispute}
/>
{insufficientBalance && (
<ErrorButtonMessage>
<ClosedCircleIcon /> Insufficient balance
</ErrorButtonMessage>
)}
</div>
);
};

export default RaiseDisputeButton;
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,11 @@ const TimeOutButton: React.FC = () => {
const isBuyer = useMemo(() => address?.toLowerCase() === buyer?.toLowerCase(), [address, buyer]);
const refetchQuery = useQueryRefetch();

const { data: timeOutByBuyerConfig } = useSimulateEscrowUniversalTimeOutByBuyer({
const { data: timeOutByBuyerConfig, isLoading: isLoadingBuyerConfig, isError: isErrorBuyerConfig } = useSimulateEscrowUniversalTimeOutByBuyer({
args: [BigInt(id)],
});

const { data: timeOutBySellerConfig } = useSimulateEscrowUniversalTimeOutBySeller({
const { data: timeOutBySellerConfig, isLoading: isLoadingSellerConfig, isError: isErrorSellerConfig } = useSimulateEscrowUniversalTimeOutBySeller({
args: [BigInt(id)],
});

Expand Down Expand Up @@ -61,7 +61,20 @@ const TimeOutButton: React.FC = () => {
}
};

return <Button isLoading={isSending} disabled={isSending} text="Claim full payment back" onClick={handleTimeout} />;
return (
<Button
isLoading={isSending || isLoadingBuyerConfig || isLoadingSellerConfig}
disabled={
isSending ||
isLoadingBuyerConfig ||
isLoadingSellerConfig ||
isErrorBuyerConfig ||
isErrorSellerConfig
}
text="Claim full payment back"
onClick={handleTimeout}
/>
);
};

export default TimeOutButton;
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const ClaimFullPaymentButton: React.FC = () => {
const publicClient = usePublicClient();
const { id } = useTransactionDetailsContext();

const { data: executeTransactionConfig } = useSimulateEscrowUniversalExecuteTransaction({
const { data: executeTransactionConfig, isLoading, isError } = useSimulateEscrowUniversalExecuteTransaction({
args: [id],
});

Expand Down Expand Up @@ -46,8 +46,8 @@ const ClaimFullPaymentButton: React.FC = () => {
return (
<>
<Button
isLoading={isSending}
disabled={isSending}
isLoading={isSending || isLoading}
disabled={isSending || isLoading || isError}
text={"No. Claim full payment"}
onClick={handleExecuteTransaction}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const ReleasePaymentButton: React.FC = () => {
const { id, amount } = useTransactionDetailsContext();
const refetchQuery = useQueryRefetch();

const { data: releaseFullPaymentConfig } = useSimulateEscrowUniversalPay({
const { data: releaseFullPaymentConfig, isLoading, isError } = useSimulateEscrowUniversalPay({
args: [id, amount],
});

Expand Down Expand Up @@ -44,8 +44,8 @@ const ReleasePaymentButton: React.FC = () => {
return (
<>
<Button
isLoading={isSending}
disabled={isSending}
isLoading={isSending || isLoading}
disabled={isSending || isLoading || isError}
text={"Yes. Release full payment"}
onClick={handleReleasePayment}
/>
Expand Down
Loading