Skip to content

Commit 032e6c3

Browse files
murzinvwilldeacon
authored andcommitted
arm64: cpufeature: Remove cpu_has_fwb() check
cpu_has_fwb() is supposed to warn user is following architectural requirement is not valid: LoUU, bits [29:27] - Level of Unification Uniprocessor for the cache hierarchy. Note When FEAT_S2FWB is implemented, the architecture requires that this field is zero so that no levels of data cache need to be cleaned in order to manage coherency with instruction fetches. LoUIS, bits [23:21] - Level of Unification Inner Shareable for the cache hierarchy. Note When FEAT_S2FWB is implemented, the architecture requires that this field is zero so that no levels of data cache need to be cleaned in order to manage coherency with instruction fetches. It is not really clear what user have to do if assertion fires. Having assertions about the CPU design like this inspire even more assertions to be added and the kernel definitely is not the right place for that, so let's remove cpu_has_fwb() altogether. Signed-off-by: Vladimir Murzin <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Will Deacon <[email protected]>
1 parent 16860a2 commit 032e6c3

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

arch/arm64/kernel/cpufeature.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1775,14 +1775,6 @@ static void cpu_copy_el2regs(const struct arm64_cpu_capabilities *__unused)
17751775
write_sysreg(read_sysreg(tpidr_el1), tpidr_el2);
17761776
}
17771777

1778-
static void cpu_has_fwb(const struct arm64_cpu_capabilities *__unused)
1779-
{
1780-
u64 val = read_sysreg_s(SYS_CLIDR_EL1);
1781-
1782-
/* Check that CLIDR_EL1.LOU{U,IS} are both 0 */
1783-
WARN_ON(CLIDR_LOUU(val) || CLIDR_LOUIS(val));
1784-
}
1785-
17861778
#ifdef CONFIG_ARM64_PAN
17871779
static void cpu_enable_pan(const struct arm64_cpu_capabilities *__unused)
17881780
{
@@ -2144,7 +2136,6 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
21442136
.field_pos = ID_AA64MMFR2_FWB_SHIFT,
21452137
.min_field_value = 1,
21462138
.matches = has_cpuid_feature,
2147-
.cpu_enable = cpu_has_fwb,
21482139
},
21492140
{
21502141
.desc = "ARMv8.4 Translation Table Level",

0 commit comments

Comments
 (0)