forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
followupThis is a possible follow-up someone can work onThis is a possible follow-up someone can work onneed to confirmNeed to confirm if this is still needed or already doneNeed to confirm if this is still needed or already done
Description
mentioned in: bitcoin#33415
"ACK 1b1f359
bitcoin#33106 backport is naturally a bit tricky to review, especially as I didn't review the original PR.
That said, git-range-diff helped out a fair bit e.g. git range-diff e5f896bb1f052fb8c7811c6024cb49143b427512..ba84a25deec0b3b9b94ee51b373e715fec995791 6090af0d350..2e756e8b02d uses the range-diff algo on the two commit ranges, which is pretty neat! It helped me identify the "massaging" that was needed for the backport, which looks fine to me.
I wonder if we want to also include the getmininginfo followup here too? :hide: 9169a50 (#33189)" - willcl-ark
Metadata
Metadata
Assignees
Labels
followupThis is a possible follow-up someone can work onThis is a possible follow-up someone can work onneed to confirmNeed to confirm if this is still needed or already doneNeed to confirm if this is still needed or already done