Skip to content

Commit a6555f8

Browse files
YueHaibingjmberg-intel
YueHaibing
authored andcommitted
mac80211: Drop frames from invalid MAC address in ad-hoc mode
WARNING: CPU: 1 PID: 9 at net/mac80211/sta_info.c:554 sta_info_insert_rcu+0x121/0x12a0 Modules linked in: CPU: 1 PID: 9 Comm: kworker/u8:1 Not tainted 5.14.0-rc7+ #253 Workqueue: phy3 ieee80211_iface_work RIP: 0010:sta_info_insert_rcu+0x121/0x12a0 ... Call Trace: ieee80211_ibss_finish_sta+0xbc/0x170 ieee80211_ibss_work+0x13f/0x7d0 ieee80211_iface_work+0x37a/0x500 process_one_work+0x357/0x850 worker_thread+0x41/0x4d0 If an Ad-Hoc node receives packets with invalid source MAC address, it hits a WARN_ON in sta_info_insert_check(), this can spam the log. Signed-off-by: YueHaibing <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Johannes Berg <[email protected]>
1 parent fe94bac commit a6555f8

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/mac80211/rx.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4131,7 +4131,8 @@ static bool ieee80211_accept_frame(struct ieee80211_rx_data *rx)
41314131
if (!bssid)
41324132
return false;
41334133
if (ether_addr_equal(sdata->vif.addr, hdr->addr2) ||
4134-
ether_addr_equal(sdata->u.ibss.bssid, hdr->addr2))
4134+
ether_addr_equal(sdata->u.ibss.bssid, hdr->addr2) ||
4135+
!is_valid_ether_addr(hdr->addr2))
41354136
return false;
41364137
if (ieee80211_is_beacon(hdr->frame_control))
41374138
return true;

0 commit comments

Comments
 (0)