Skip to content

Commit 6d90b64

Browse files
gobenjikuba-moo
authored andcommitted
vxlan: Cleanup IFLA_VXLAN_PORT_RANGE entry in vxlan_get_size()
This patch is basically a followup to commit 4e4b179 ("vxlan: Add missing entries to vxlan_get_size()"). All of the attributes in vxlan_get_size() appear in the same order that they are filled in vxlan_fill_info() except for IFLA_VXLAN_PORT_RANGE. For consistency, move that entry to match its order and add a comment, like for all other entries. Signed-off-by: Benjamin Poirier <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent a421370 commit 6d90b64

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/net/vxlan/vxlan_core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4389,7 +4389,6 @@ static void vxlan_dellink(struct net_device *dev, struct list_head *head)
43894389

43904390
static size_t vxlan_get_size(const struct net_device *dev)
43914391
{
4392-
43934392
return nla_total_size(sizeof(__u32)) + /* IFLA_VXLAN_ID */
43944393
nla_total_size(sizeof(struct in6_addr)) + /* IFLA_VXLAN_GROUP{6} */
43954394
nla_total_size(sizeof(__u32)) + /* IFLA_VXLAN_LINK */
@@ -4407,14 +4406,15 @@ static size_t vxlan_get_size(const struct net_device *dev)
44074406
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_COLLECT_METADATA */
44084407
nla_total_size(sizeof(__u32)) + /* IFLA_VXLAN_AGEING */
44094408
nla_total_size(sizeof(__u32)) + /* IFLA_VXLAN_LIMIT */
4410-
nla_total_size(sizeof(struct ifla_vxlan_port_range)) +
44114409
nla_total_size(sizeof(__be16)) + /* IFLA_VXLAN_PORT */
44124410
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_UDP_CSUM */
44134411
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_UDP_ZERO_CSUM6_TX */
44144412
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_UDP_ZERO_CSUM6_RX */
44154413
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_REMCSUM_TX */
44164414
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_REMCSUM_RX */
44174415
nla_total_size(sizeof(__u8)) + /* IFLA_VXLAN_LOCALBYPASS */
4416+
/* IFLA_VXLAN_PORT_RANGE */
4417+
nla_total_size(sizeof(struct ifla_vxlan_port_range)) +
44184418
nla_total_size(0) + /* IFLA_VXLAN_GBP */
44194419
nla_total_size(0) + /* IFLA_VXLAN_GPE */
44204420
nla_total_size(0) + /* IFLA_VXLAN_REMCSUM_NOPARTIAL */

0 commit comments

Comments
 (0)