Skip to content

Fix Keras serialization naming collision #2001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ianstenbit merged 7 commits into from
Aug 1, 2023
Merged

Fix Keras serialization naming collision #2001

ianstenbit merged 7 commits into from
Aug 1, 2023

Conversation

@ianstenbit
Copy link
Contributor

@ianstenbit ianstenbit commented Aug 1, 2023

Fixes #1998

@ianstenbit ianstenbit mentioned this pull request Aug 1, 2023
Closed
@ianstenbit
Copy link
Contributor Author

ianstenbit commented Aug 1, 2023

/gcbrun

@ianstenbit ianstenbit requested a review from jbischof August 1, 2023 17:15
jbischof
jbischof approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@jbischof jbischof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@ianstenbit ianstenbit merged commit 45292eb into keras-team:master Aug 1, 2023
BjarneHerland added a commit to BjarneHerland/keras-cv that referenced this pull request Sep 15, 2023
@BjarneHerland
Fixing e.g. issue from keras-team#2070
1e2b024 
Add explicit package-specification for more modules like done in keras-team#2001
@BjarneHerland BjarneHerland mentioned this pull request Sep 15, 2023
Closed
5 tasks
BjarneHerland added a commit to BjarneHerland/keras-cv that referenced this pull request Sep 15, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in keras-t…
ab488e8 
…eam#2001

Explicitly specify full package-name for several methods upon registering as serialisable.
Fixes keras-team#2070
BjarneHerland added a commit to BjarneHerland/keras-cv that referenced this pull request Sep 19, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in keras-t…
328fc88 
…eam#2001

Explicitly specify full package-name for several methods upon registering as serialisable.
Fixes keras-team#2070
BjarneHerland added a commit to BjarneHerland/keras-cv that referenced this pull request Sep 19, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in keras-t…
3bd888e 
…eam#2001

Explicitly specify full package-name for several methods upon registering as serialisable.
Fixes keras-team#2070
@BjarneHerland BjarneHerland mentioned this pull request Sep 19, 2023
Merged
5 tasks
BjarneHerland added a commit to BjarneHerland/keras-cv that referenced this pull request Sep 20, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in keras-t…
6d0d570 
…eam#2001
BjarneHerland added a commit to BjarneHerland/keras-cv that referenced this pull request Sep 22, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in keras-t…
9c79dd8 
…eam#2001
ianstenbit pushed a commit that referenced this pull request Sep 22, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in #2001 (#…
e5cd24a 
…2077)

* Test to demonstrate failures in import

* Explicitly specify full package for more modules, as shown in #2001
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
@ianstenbit
Fix Keras serialization naming collision (keras-team#2001)
aa670b7 
* Structure for Namex export

* Switch to programmatic API generation with Namex

* Fix missing import

* Fix preset class names

* Fix serialization collision
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
@BjarneHerland
Explicitly specify full package for more modules, as shown in keras-t…
f5cab52 
…eam#2001 (keras-team#2077)

* Test to demonstrate failures in import

* Explicitly specify full package for more modules, as shown in keras-team#2001
yuvraj-wale pushed a commit to yuvraj-wale/keras-cv that referenced this pull request Feb 8, 2024
@BjarneHerland @yuvraj-wale
Explicitly specify full package for more modules, as shown in keras-t…
2ef46ee 
…eam#2001 (keras-team#2077)

* Test to demonstrate failures in import

* Explicitly specify full package for more modules, as shown in keras-team#2001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jbischof jbischof jbischof approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ValueError: keras_cv>FeaturePyramid has already been registered to <class 'keras_cv.layers.feature_pyramid.FeaturePyramid'>

2 participants

@ianstenbit @jbischof