Skip to content

PHP8 for V1 #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 2, 2023
Merged

PHP8 for V1 #51

merged 4 commits into from
Feb 2, 2023

Conversation

@zajca
Copy link
Member

@zajca zajca commented Feb 1, 2023

No description provided.

@zajca zajca force-pushed the zajca-php8-for-v1 branch from 91deb16 to 027b0e9 Compare February 1, 2023 14:27
@zajca zajca requested review from a team and martinjunger and removed request for a team and martinjunger February 1, 2023 14:29
martinjunger
martinjunger reviewed Feb 2, 2023
View reviewed changes
composer.json Outdated
"tests": "phpunit",
"ci": [
"@composer validate --strict",
"@build"
Copy link

@martinjunger martinjunger Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v buildu to pise

Run composer ci
./composer.json is valid
You made a reference to a non-existent script @build

Jakej byl zamer s tim @build - pustit phpunit testy? Potom by tam mel byt @tests ;-)

Copy link
Member Author

@zajca zajca Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D opraveno, sorry

Copy link

@martinjunger martinjunger Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bylo by fajn, kdyby to ten skript skoncil, zajimavy ze to jen vypise warning a frci to dal...

Copy link
Member Author

@zajca zajca Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To je ale vlastnost composeru když je tam ta stage není nebo je prázdná tak vrátí status code 0

@zajca zajca requested a review from martinjunger February 2, 2023 10:44
martinjunger
martinjunger reviewed Feb 2, 2023
View reviewed changes
tests/CsvFileErrorsTest.php
Comment on lines 33 to 35
if (PHP_MAJOR_VERSION > 7) {
$this->markTestSkipped();
}
Copy link

@martinjunger martinjunger Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proc tohle? Slo by do toho skipped pridat description?

Copy link
Member Author

@zajca zajca Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

přidal sem

martinjunger
martinjunger reviewed Feb 2, 2023
View reviewed changes
tests/CsvFileErrorsTest.php
return [
["", 'Filename cannot be empty'],
["\0", 'fopen() expects parameter 1 to be a valid path, string given'],
// ["\0", 'fopen() expects parameter 1 to be a valid path, string given'],
Copy link

@martinjunger martinjunger Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

co s timhle, smazat nebo pridat komentar proc je to zakomentovany?

Copy link
Member Author

@zajca zajca Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v php8 sa to chová trochu jinak a nejde to moc rozumně vyřesit bez hacků a ztráty dalšího času pro knihovnu co je obsolete.

Copy link

@martinjunger martinjunger Feb 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

martinjunger
martinjunger reviewed Feb 2, 2023
View reviewed changes
Copy link

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jen par nejasnosti v testech...

martinjunger
martinjunger approved these changes Feb 2, 2023
View reviewed changes
Copy link

@martinjunger martinjunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zajca zajca merged commit 62398e5 into v1 Feb 2, 2023
@zajca zajca deleted the zajca-php8-for-v1 branch February 2, 2023 10:54
@martinjunger
Copy link

martinjunger commented Feb 2, 2023 •
edited
Loading

Koukam jeste do tech testu, je tam 1 risky:

There was 1 risky test:

1) Keboola\Csv\Tests\CsvFileTest::testInitInvalidFileShouldNotThrowException
This test did not perform any assertions

/home/runner/work/php-csv/php-csv/tests/CsvFileTest.php:146

Bylo by dobry do toho testu pridat

$this->expectNotToPerformAssertions();

Edit: ale vlastne je to pro starou verzi v1, tak asi OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@martinjunger martinjunger martinjunger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zajca @martinjunger