fix: disable SneakCurrent in exclusive motion #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of SneakCurrent with inclusive=0 (t-like) motion wasn't considered
properly:
- The semantics are that it's like a search highlight for "match under
cursor", but exclusive motion lands the cursor *next* to the match
- SneakCurrent's implementation assumes the cursor is at match start
when the highlight is shown, which caused a hl bug extending the hl
beyond the match on exclusive
tuurep
force-pushed
the
disable-sneakcurrent-in-exclusive-motion
branch
from
edf6a1b to
942f158
Compare
Owner
|
This makes sense. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I researched the
inclusive = 0problems in #322 (comment), and definitely think the waySneakCurrentis done can't be used withinclusive = 0motions, for example:with 2-char exclusive sneak (most importantly where it higlights the
qon backwards motion).IMO this is sufficient as a fix,
though it's possible to fix it so that the hl is on the right spot on exclusive too, I just think it would look uglier on the
t-motion (<Plug>Sneak_t, 1 char), so all we'd achieve would be to add more visual noise to a common motion.P.S. in #322 I was very confused about where exactly the cursor should land on a backwards exclusive motion when match is longer than 1 char, but I think #83 mostly explains it so I suppose there are no more problems from #322