Restore time for current user's messages, and allow showing deleted messages #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
|
Member
|
Trying this PR on Binder, should there be some text to indicate a message has been deleted? 
|
Collaborator
Author
|
Thanks for looking the PR @jtpio You're right, actually I tested it only with a collaborator, and we can see the message in this case. The message deleted and edited are added to the header, which is not displayed anymore for the current user, only for collaborators, after #298. I'll think about it, because with the current state we also loose the time and the edited information for the current user (the message edition is not restored yet, though). |
brichet
changed the title
Collaborator
Author
It should be fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an setting to show the deleted message in the chat.
It also restores a minimal header of the current user's messages, to display the time of the message and the deleted status.
Part of #303