-
Notifications
You must be signed in to change notification settings - Fork 305
Closed
Description
I had to pull 6.2.0 again, because:
- a channel's
get_msg()previously had ablock=Truekwarg, that was removed in6.2.0. get_msg()is now always async, regardless of the client type (blocking or async). Previously, it was async for an async client and sync for a blocking client.
For the next release, I will fix 1. and add block=True back. For 2., we offer higher-level methods, e.g. kc.get_iopub_msg() that should be prefered over kc.iopub_channel.get_msg(), since it does the right thing (it is async for an async client and sync for a blocking client). I made the relevant changes in ipython/ipykernel#634 for instance, but I don't know if get_msg() is used in other projects.
If we consider that get_msg() now being always async is an API breaking change, then we should make a major release (7.0.0a0). Otherwise, a 6.2.1a0 would be enough. How do people feel about this?
SylvainCorlay
Metadata
Metadata
Assignees
Labels
No labels