Skip to content

Commit 278dd76

Browse files
twalcarimathbunnyru
twalcari
and
mathbunnyru
authored
Add jupyter/pytorch-notebook (#1936)
* Add PyTorch image * Fix linting errors * Fix link to pytorch website * Address review comments * Fix PytorchVersionTagger * Remove "+cpu" suffix from pytorch version tag * Update selecting.md * Rename pytorch-notebook/.dockerignore to images/pytorch-notebook/.dockerignore * Rename pytorch-notebook/Dockerfile to images/pytorch-notebook/Dockerfile * Rename pytorch-notebook/README.md to images/pytorch-notebook/README.md * Add pytorch-notebook to registry-overviews * Add registry to pytorch image * Use Quay.io * Remove incorrect link * Update action.yml * Update docker.yml * Remove information about Docker Hub, because this image won't be uploaded to Docker Hub * Update docker.yml * Update action.yml * Add pytorch-notebook to registry-move.yml --------- Co-authored-by: Ayaz Salikhov <[email protected]> Co-authored-by: Ayaz Salikhov <[email protected]>
1 parent 0a75e3d commit 278dd76

File tree

17 files changed

+135
-13
lines changed

17 files changed

+135
-13
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ body:
2626
- julia-notebook
2727
- minimal-notebook
2828
- pyspark-notebook
29+
- pytorch-notebook
2930
- r-notebook
3031
- scipy-notebook
3132
- tensorflow-notebook

‎.github/ISSUE_TEMPLATE/feature_request.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ body:
2424
- julia-notebook
2525
- minimal-notebook
2626
- pyspark-notebook
27+
- pytorch-notebook
2728
- r-notebook
2829
- scipy-notebook
2930
- tensorflow-notebook

‎.github/actions/download-manifests/action.yml‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,18 @@ runs:
9999
with:
100100
name: tensorflow-notebook-x86_64-history_line
101101
path: ${{ inputs.hist-lines-dir }}
102+
- name: Download artifact 📥
103+
uses: actions/download-artifact@v3
104+
if: inputs.fast-build == 'false'
105+
with:
106+
name: pytorch-notebook-aarch64-history_line
107+
path: ${{ inputs.hist-lines-dir }}
108+
- name: Download artifact 📥
109+
uses: actions/download-artifact@v3
110+
if: inputs.fast-build == 'false'
111+
with:
112+
name: pytorch-notebook-x86_64-history_line
113+
path: ${{ inputs.hist-lines-dir }}
102114
- name: Download artifact 📥
103115
uses: actions/download-artifact@v3
104116
if: inputs.fast-build == 'false'
@@ -216,6 +228,18 @@ runs:
216228
with:
217229
name: tensorflow-notebook-x86_64-manifest
218230
path: ${{ inputs.manifests-dir }}
231+
- name: Download artifact 📥
232+
uses: actions/download-artifact@v3
233+
if: inputs.fast-build == 'false'
234+
with:
235+
name: pytorch-notebook-aarch64-manifest
236+
path: ${{ inputs.manifests-dir }}
237+
- name: Download artifact 📥
238+
uses: actions/download-artifact@v3
239+
if: inputs.fast-build == 'false'
240+
with:
241+
name: pytorch-notebook-x86_64-manifest
242+
path: ${{ inputs.manifests-dir }}
219243
- name: Download artifact 📥
220244
uses: actions/download-artifact@v3
221245
if: inputs.fast-build == 'false'

‎.github/workflows/docker.yml‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,26 @@ jobs:
198198
needs: [x86_64-scipy]
199199
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}
200200

201+
aarch64-pytorch:
202+
uses: ./.github/workflows/docker-build-test-upload.yml
203+
with:
204+
parent-image: scipy-notebook
205+
image: pytorch-notebook
206+
platform: aarch64
207+
runs-on: ARM64
208+
needs: [aarch64-scipy]
209+
if: github.repository_owner == 'jupyter' && !contains(github.event.pull_request.title, '[FAST_BUILD]')
210+
211+
x86_64-pytorch:
212+
uses: ./.github/workflows/docker-build-test-upload.yml
213+
with:
214+
parent-image: scipy-notebook
215+
image: pytorch-notebook
216+
platform: x86_64
217+
runs-on: ubuntu-latest
218+
needs: [x86_64-scipy]
219+
if: ${{ !contains(github.event.pull_request.title, '[FAST_BUILD]') }}
220+
201221
aarch64-datascience:
202222
uses: ./.github/workflows/docker-build-test-upload.yml
203223
with:
@@ -277,6 +297,7 @@ jobs:
277297
r-notebook,
278298
julia-notebook,
279299
tensorflow-notebook,
300+
pytorch-notebook,
280301
datascience-notebook,
281302
pyspark-notebook,
282303
all-spark-notebook,
@@ -290,6 +311,7 @@ jobs:
290311
aarch64-r,
291312
aarch64-julia,
292313
aarch64-tensorflow,
314+
aarch64-pytorch,
293315
aarch64-datascience,
294316
aarch64-pyspark,
295317
aarch64-all-spark,
@@ -329,6 +351,7 @@ jobs:
329351
r-notebook,
330352
julia-notebook,
331353
tensorflow-notebook,
354+
pytorch-notebook,
332355
datascience-notebook,
333356
pyspark-notebook,
334357
all-spark-notebook,
@@ -342,6 +365,7 @@ jobs:
342365
x86_64-r,
343366
x86_64-julia,
344367
x86_64-tensorflow,
368+
x86_64-pytorch,
345369
x86_64-datascience,
346370
x86_64-pyspark,
347371
x86_64-all-spark,
@@ -380,6 +404,7 @@ jobs:
380404
r-notebook,
381405
julia-notebook,
382406
tensorflow-notebook,
407+
pytorch-notebook,
383408
datascience-notebook,
384409
pyspark-notebook,
385410
all-spark-notebook,

‎.github/workflows/registry-move.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ jobs:
5151
r-notebook,
5252
julia-notebook,
5353
tensorflow-notebook,
54+
pytorch-notebook,
5455
datascience-notebook,
5556
pyspark-notebook,
5657
all-spark-notebook,

‎.github/workflows/registry-overviews.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ jobs:
4242
r-notebook,
4343
julia-notebook,
4444
tensorflow-notebook,
45+
pytorch-notebook,
4546
datascience-notebook,
4647
pyspark-notebook,
4748
all-spark-notebook,

‎Makefile‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ ALL_IMAGES:= \
1717
julia-notebook \
1818
scipy-notebook \
1919
tensorflow-notebook \
20+
pytorch-notebook \
2021
datascience-notebook \
2122
pyspark-notebook \
2223
all-spark-notebook

‎docs/images/inherit.svg‎

Lines changed: 19 additions & 12 deletions
Loading

‎docs/using/selecting.md‎

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,17 @@ It contains:
187187
- Everything in `jupyter/scipy-notebook` and its ancestor images
188188
- [tensorflow](https://www.tensorflow.org/) machine learning library
189189

190+
### jupyter/pytorch-notebook
191+
192+
[Source on GitHub](https://github.com/jupyter/docker-stacks/tree/main/images/pytorch-notebook) |
193+
[Dockerfile commit history](https://github.com/jupyter/docker-stacks/commits/main/images/pytorch-notebook/Dockerfile) |
194+
[Quay.io image tags](https://quay.io/repository/jupyter/pytorch-notebook?tab=tags)
195+
196+
`jupyter/pytorch-notebook` includes popular Python deep learning libraries.
197+
198+
- Everything in `jupyter/scipy-notebook` and its ancestor images
199+
- [pytorch](https://pytorch.org/) machine learning library
200+
190201
### jupyter/datascience-notebook
191202

192203
[Source on GitHub](https://github.com/jupyter/docker-stacks/tree/main/images/datascience-notebook) |
@@ -234,7 +245,7 @@ The following diagram depicts the build dependency tree of the core images. (i.e
234245
Any given image inherits the complete content of all ancestor images pointing to it.
235246

236247
[![Image inheritance
237-
diagram](../images/inherit.svg)](http://interactive.blockdiag.com/?compression=deflate&src=eJyFjkFuwkAMRfecwsqKLuYACMEJuqPLSshJHDAZ7GjGIwSIuzPTRaWJWmX7_vP_br12Y894gucKoKcBk7fjoGKRHwQ72Gwz18AkhsYqGU0aLCDbdpWjJrVJLH3L-vPrADe2c85ZDAJ5wkgfDbg99HmFgouG3RjdoEn6n7ZS_l9W7trc4ESNWtWxyBUoxpWFr-grac6KFzue7pVVk-I0RhI1DF5vv7z5W80vYqYkHS1Oh0XjkjzjwnPTPU4Yxsqas-Kh925uvt4imKoO)
248+
diagram](../images/inherit.svg)](http://interactive.blockdiag.com/?compression=deflate&src=eJyFz8FOwzAMgOH7nsLqCQ55ADTBE3CDIxJyU5eZZnaUOJoK2rsv4YCUSlOvv784yRjULxPjF_weACaasQT7nFUs8w_BMzwda9fEJIbGKjVFTZaQ7Xioo6GMRax8yMPr-xtc2E51zmKQKBBmehzAvcBUb6HksqFfspu1yPS3rS2_N2vnxrrBiRqNqkvDXWjizMJnDB3atuay57h2qi_NDEaSNc1BL_99uEPjapr8ac_Vr2CtJJ52n5h2xXcJjDufiGuOmJZObVtzGILbyusNkda3zw)
238249

239250
### Builds
240251

‎images/pytorch-notebook/.dockerignore‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Documentation
2+
README.md

0 commit comments

Comments
 (0)