diff --git a/lib/rules/no-render-return-value.js b/lib/rules/no-render-return-value.js index e31552de73..6303c35224 100644 --- a/lib/rules/no-render-return-value.js +++ b/lib/rules/no-render-return-value.js @@ -27,6 +27,15 @@ module.exports = { // Public // -------------------------------------------------------------------------- + let calleeObjectName = /^ReactDOM$/; + if (versionUtil.testReactVersion(context, '15.0.0')) { + calleeObjectName = /^ReactDOM$/; + } else if (versionUtil.testReactVersion(context, '0.14.0')) { + calleeObjectName = /^React(DOM)?$/; + } else if (versionUtil.testReactVersion(context, '0.13.0')) { + calleeObjectName = /^React$/; + } + return { CallExpression: function(node) { @@ -36,15 +45,6 @@ module.exports = { return; } - let calleeObjectName = /^ReactDOM$/; - if (versionUtil.testReactVersion(context, '15.0.0')) { - calleeObjectName = /^ReactDOM$/; - } else if (versionUtil.testReactVersion(context, '0.14.0')) { - calleeObjectName = /^React(DOM)?$/; - } else if (versionUtil.testReactVersion(context, '0.13.0')) { - calleeObjectName = /^React$/; - } - if ( callee.object.type !== 'Identifier' || !calleeObjectName.test(callee.object.name) || diff --git a/tests/lib/rules/no-render-return-value.js b/tests/lib/rules/no-render-return-value.js index 210bb75ae4..4b8a45825a 100644 --- a/tests/lib/rules/no-render-return-value.js +++ b/tests/lib/rules/no-render-return-value.js @@ -54,6 +54,17 @@ ruleTester.run('no-render-return-value', rule, { version: '0.13.0' } } + }, { + code: 'var foo = React.render(
, root);', + settings: { + react: { + version: '0.0.1' + } + } + }, { + code: 'var foo = render(
, root)' + }, { + code: 'var foo = ReactDom.renderder(
, root)' }], invalid: [{