From eae31a08cef54a0f051a4cd4917a3d24e97feb40 Mon Sep 17 00:00:00 2001 From: Tom Date: Tue, 18 Sep 2018 10:39:16 +0100 Subject: [PATCH 1/3] add example of complete react/jsx-no-target-blank rule --- docs/rules/jsx-no-target-blank.md | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/docs/rules/jsx-no-target-blank.md b/docs/rules/jsx-no-target-blank.md index be20205c2a..8ce05daa48 100644 --- a/docs/rules/jsx-no-target-blank.md +++ b/docs/rules/jsx-no-target-blank.md @@ -15,27 +15,35 @@ This rule aims to prevent user generated links from creating security vulnerabil There are two main options for the rule: -* `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) -* `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link +- `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) +- `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link +```json +"react/jsx-no-target-blank": [, { enforceDynamicLinks: }] +``` + +- enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0. +- enforce: optional string, defaults to "always" ### always (default) When {"enforceDynamicLinks": "always"} is set, the following patterns are considered errors: ```jsx -var Hello = -var Hello = +var Hello = ; +var Hello = ; ``` The following patterns are **not** considered errors: ```jsx -var Hello =

-var Hello = -var Hello = -var Hello = -var Hello = +var Hello =

; +var Hello = ( + +); +var Hello = ; +var Hello = ; +var Hello = ; ``` ### never @@ -43,7 +51,7 @@ var Hello = When {"enforceDynamicLinks": "never"} is set, the following patterns are **not** considered errors: ```jsx -var Hello = +var Hello = ; ``` ## When Not To Use It From 658379a52fe566bb23cfce72bd4ab1541581b290 Mon Sep 17 00:00:00 2001 From: Tom Date: Tue, 18 Sep 2018 10:56:25 +0100 Subject: [PATCH 2/3] undid editor prettifying opinions --- docs/rules/jsx-no-target-blank.md | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/docs/rules/jsx-no-target-blank.md b/docs/rules/jsx-no-target-blank.md index 8ce05daa48..438dc2f08a 100644 --- a/docs/rules/jsx-no-target-blank.md +++ b/docs/rules/jsx-no-target-blank.md @@ -15,35 +15,34 @@ This rule aims to prevent user generated links from creating security vulnerabil There are two main options for the rule: -- `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) -- `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link +* `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) +* `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link ```json "react/jsx-no-target-blank": [, { enforceDynamicLinks: }] ``` -- enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0. -- enforce: optional string, defaults to "always" +* enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0. +* enforce: optional string, defaults to "always" + ### always (default) When {"enforceDynamicLinks": "always"} is set, the following patterns are considered errors: ```jsx -var Hello = ; -var Hello = ; +var Hello = +var Hello = ``` The following patterns are **not** considered errors: ```jsx -var Hello =

; -var Hello = ( - -); -var Hello = ; -var Hello = ; -var Hello = ; +var Hello =

+var Hello = +var Hello = +var Hello = +var Hello = ``` ### never @@ -51,9 +50,9 @@ var Hello = ; When {"enforceDynamicLinks": "never"} is set, the following patterns are **not** considered errors: ```jsx -var Hello = ; +var Hello = ``` ## When Not To Use It -If you do not have any external links, you can disable this rule +If you do not have any external links, you can disable this rule \ No newline at end of file From ac78b513430bbb46c84846e6ea021880f86b36e2 Mon Sep 17 00:00:00 2001 From: atomcorp Date: Wed, 19 Sep 2018 23:10:21 +0100 Subject: [PATCH 3/3] quotes for json key, reordered information --- docs/rules/jsx-no-target-blank.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/docs/rules/jsx-no-target-blank.md b/docs/rules/jsx-no-target-blank.md index 438dc2f08a..dd0cdb4c9b 100644 --- a/docs/rules/jsx-no-target-blank.md +++ b/docs/rules/jsx-no-target-blank.md @@ -12,21 +12,17 @@ This rule aims to prevent user generated links from creating security vulnerabil `rel='noreferrer noopener'` for external links, and optionally any dynamically generated links. ## Rule Options - -There are two main options for the rule: - -* `{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) -* `{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link - ```json -"react/jsx-no-target-blank": [, { enforceDynamicLinks: }] +... +"react/jsx-no-target-blank": [, { "enforceDynamicLinks": }] +... ``` * enabled: for enabling the rule. 0=off, 1=warn, 2=error. Defaults to 0. -* enforce: optional string, defaults to "always" - +* enforce: optional string, 'always' or 'never' ### always (default) +`{"enforceDynamicLinks": "always"}` enforces the rule if the href is a dynamic link (default) When {"enforceDynamicLinks": "always"} is set, the following patterns are considered errors: @@ -47,6 +43,8 @@ var Hello = ### never +`{"enforceDynamicLinks": "never"}` does not enforce the rule if the href is a dynamic link + When {"enforceDynamicLinks": "never"} is set, the following patterns are **not** considered errors: ```jsx