Skip to content

Commit c6c5e3b

Browse files
committed
[Breaking] add rules to recommended configuration:
- `no-danger-with-children`: Fixes #748 - `no-string-refs`: Fixes #749 - `jsx-key`: Fixes #750 - `jsx-no-comment-textnodes`: Fixes #751 - `jsx-no-target-blank`: Fixes #752 - `no-unescaped-entities`: Fixes #841 - `no-children-prop`: Fixes #842 -
1 parent 444c096 commit c6c5e3b

8 files changed

+15
-8
lines changed

index.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -112,16 +112,23 @@ module.exports = {
112112
},
113113
rules: {
114114
'react/display-name': 2,
115+
'react/jsx-key': 2,
116+
'react/jsx-no-comment-textnodes': 2,
115117
'react/jsx-no-duplicate-props': 2,
118+
'react/jsx-no-target-blank': 2,
116119
'react/jsx-no-undef': 2,
117120
'react/jsx-uses-react': 2,
118121
'react/jsx-uses-vars': 2,
122+
'react/no-children-prop': 2,
123+
'react/no-danger-with-children': 2,
119124
'react/no-deprecated': 2,
120125
'react/no-direct-mutation-state': 2,
121126
'react/no-find-dom-node': 2,
122127
'react/no-is-mounted': 2,
123-
'react/no-unknown-property': 2,
124128
'react/no-render-return-value': 2,
129+
'react/no-string-refs': 2,
130+
'react/no-unescaped-entities': 2,
131+
'react/no-unknown-property': 2,
125132
'react/prop-types': 2,
126133
'react/react-in-jsx-scope': 2,
127134
'react/require-render-return': 2

lib/rules/jsx-key.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ module.exports = {
1717
docs: {
1818
description: 'Report missing `key` props in iterators/collection literals',
1919
category: 'Possible Errors',
20-
recommended: false
20+
recommended: true
2121
},
2222
schema: []
2323
},

lib/rules/jsx-no-comment-textnodes.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module.exports = {
1313
docs: {
1414
description: 'Comments inside children section of tag should be placed inside braces',
1515
category: 'Possible Errors',
16-
recommended: false
16+
recommended: true
1717
},
1818

1919
schema: [{

lib/rules/jsx-no-target-blank.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ module.exports = {
1313
docs: {
1414
description: 'Forbid target="_blank" attribute without rel="noopener noreferrer"',
1515
category: 'Best Practices',
16-
recommended: false
16+
recommended: true
1717
},
1818
schema: []
1919
},

lib/rules/no-children-prop.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ module.exports = {
3131
docs: {
3232
description: 'Prevent passing of children as props.',
3333
category: 'Best Practices',
34-
recommended: false
34+
recommended: true
3535
},
3636
schema: []
3737
},

lib/rules/no-danger-with-children.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module.exports = {
1414
docs: {
1515
description: 'Report when a DOM element is using both children and dangerouslySetInnerHTML',
1616
category: '',
17-
recommended: false
17+
recommended: true
1818
},
1919
schema: [] // no options
2020
},

lib/rules/no-string-refs.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ module.exports = {
1515
docs: {
1616
description: 'Prevent string definitions for references and prevent referencing this.refs',
1717
category: 'Best Practices',
18-
recommended: false
18+
recommended: true
1919
},
2020
schema: []
2121
},

lib/rules/no-unescaped-entities.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module.exports = {
1818
docs: {
1919
description: 'Detect unescaped HTML entities, which might represent malformed tags',
2020
category: 'Possible Errors',
21-
recommended: false
21+
recommended: true
2222
},
2323
schema: [{
2424
type: 'object',

0 commit comments

Comments
 (0)