Deprecate require-extension rule

Author: yannickcr

README.md

@@ -97,6 +97,7 @@ Finally, enable all of the rules that you would like to use.  Use [our preset](#
 * [react/prefer-stateless-function](docs/rules/prefer-stateless-function.md): Enforce stateless React Components to be written as a pure function
 * [react/prop-types](docs/rules/prop-types.md): Prevent missing props validation in a React component definition
 * [react/react-in-jsx-scope](docs/rules/react-in-jsx-scope.md): Prevent missing `React` when using JSX
+* [react/require-extension](docs/rules/require-extension.md): Restrict file extensions that may be required
 * [react/require-optimization](docs/rules/require-optimization.md): Enforce React components to have a shouldComponentUpdate method
 * [react/require-render-return](docs/rules/require-render-return.md): Enforce ES5 or ES6 class for returning value in render function
 * [react/self-closing-comp](docs/rules/self-closing-comp.md): Prevent extra closing tags for components without children
@@ -123,7 +124,6 @@ Finally, enable all of the rules that you would like to use.  Use [our preset](#
 * [react/jsx-no-target-blank](docs/rules/jsx-no-target-blank.md): Prevent usage of unsafe `target='_blank'`
 * [react/jsx-no-undef](docs/rules/jsx-no-undef.md): Disallow undeclared variables in JSX
 * [react/jsx-pascal-case](docs/rules/jsx-pascal-case.md): Enforce PascalCase for user-defined JSX components
-* [react/jsx-require-extension](docs/rules/jsx-require-extension.md): Restrict file extensions that may be required
 * [react/jsx-sort-props](docs/rules/jsx-sort-props.md): Enforce props alphabetical sorting
 * [react/jsx-space-before-closing](docs/rules/jsx-space-before-closing.md): Validate spacing before closing bracket in JSX (fixable)
 * [react/jsx-uses-react](docs/rules/jsx-uses-react.md): Prevent React to be incorrectly marked as unused

docs/rules/jsx-require-extension.md renamed to docs/rules/require-extension.md

@@ -1,4 +1,6 @@
-# Restrict file extensions that may be required (jsx-require-extension)
+# Restrict file extensions that may be required (require-extension)
+
+**Deprecation notice**: This rule is deprecated. Please use the eslint-plugin-import [extensions](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/extensions.md) rule instead.
 
 `require()` statements should generally not include a file extension as there is a well defined mechanism for resolving a module ID to a specific file. This rule inspects the module ID being required and creates a warning if the ID contains a '.jsx' file extension.
 
@@ -29,7 +31,7 @@ The set of forbidden extensions is configurable. By default '.jsx' is blocked. I
 
 ```js
 "rules": {
-  "react/jsx-require-extension": [1, { "extensions": [".js", ".jsx"] }],
+  "react/require-extension": [1, { "extensions": [".js", ".jsx"] }],
 }
 ```
 

index.js

@@ -34,7 +34,6 @@ var rules = {
   'sort-prop-types': require('./lib/rules/sort-prop-types'),
   'jsx-boolean-value': require('./lib/rules/jsx-boolean-value'),
   'sort-comp': require('./lib/rules/sort-comp'),
-  'jsx-require-extension': require('./lib/rules/jsx-require-extension'),
   'jsx-no-duplicate-props': require('./lib/rules/jsx-no-duplicate-props'),
   'jsx-max-props-per-line': require('./lib/rules/jsx-max-props-per-line'),
   'jsx-no-literals': require('./lib/rules/jsx-no-literals'),

lib/rules/jsx-require-extension.js

@@ -5,13 +5,22 @@
  */
 'use strict';
 
+var path = require('path');
+var isWarnedForDeprecation = false;
+
 // ------------------------------------------------------------------------------
-// Rule Definition
+// Constants
 // ------------------------------------------------------------------------------
 
-var util = require('util');
-var jsxRequireExtension = require('./jsx-require-extension');
-var isWarnedForDeprecation = false;
+var DEFAULTS = {
+  extensions: ['.jsx']
+};
+
+var PKG_REGEX = /^[^\.]((?!\/).)*$/;
+
+// ------------------------------------------------------------------------------
+// Rule Definition
+// ------------------------------------------------------------------------------
 
 module.exports = {
   meta: {
@@ -36,18 +45,68 @@ module.exports = {
   },
 
   create: function(context) {
-    return util._extend(jsxRequireExtension(context), {
+
+    function isPackage(id) {
+      return PKG_REGEX.test(id);
+    }
+
+    function isRequire(expression) {
+      return expression.callee.name === 'require';
+    }
+
+    function getId(expression) {
+      return expression.arguments[0] && expression.arguments[0].value;
+    }
+
+    function getExtension(id) {
+      return path.extname(id || '');
+    }
+
+    function getExtensionsConfig() {
+      return context.options[0] && context.options[0].extensions || DEFAULTS.extensions;
+    }
+
+    var forbiddenExtensions = getExtensionsConfig().reduce(function (extensions, extension) {
+      extensions[extension] = true;
+      return extensions;
+    }, Object.create(null));
+
+    function isForbiddenExtension(ext) {
+      return ext in forbiddenExtensions;
+    }
+
+    // --------------------------------------------------------------------------
+    // Public
+    // --------------------------------------------------------------------------
+
+    return {
+
+      CallExpression: function(node) {
+        if (isRequire(node)) {
+          var id = getId(node);
+          var ext = getExtension(id);
+          if (!isPackage(id) && isForbiddenExtension(ext)) {
+            context.report({
+              node: node,
+              message: 'Unable to require module with extension \'' + ext + '\''
+            });
+          }
+        }
+      },
+
       Program: function() {
         if (isWarnedForDeprecation || /\=-(f|-format)=/.test(process.argv.join('='))) {
           return;
         }
 
         /* eslint-disable no-console */
         console.log('The react/require-extension rule is deprecated. Please ' +
-                    'use the react/jsx-require-extension rule instead.');
+                    'use the import/extensions rule from eslint-plugin-import instead.');
         /* eslint-enable no-console */
         isWarnedForDeprecation = true;
       }
-    });
+
+    };
+
   }
 };

lib/rules/require-extension.js

@@ -8,7 +8,7 @@
 // Requirements
 // ------------------------------------------------------------------------------
 
-var rule = require('../../../lib/rules/jsx-require-extension');
+var rule = require('../../../lib/rules/require-extension');
 var RuleTester = require('eslint').RuleTester;
 
 // ------------------------------------------------------------------------------
@@ -34,7 +34,7 @@ var REQUIRE_OBJECT = 'require({})';
 // ------------------------------------------------------------------------------
 
 var ruleTester = new RuleTester();
-ruleTester.run('jsx-require-extension', rule, {
+ruleTester.run('require-extension', rule, {
 
   valid: [
     {