Skip to content

Commit 7d07c37

Browse files
authored
Merge pull request #2032 from alexzherdev/jsx-fragments-message
`jsx-fragments`: improve message text
2 parents 8c6a8e2 + 7d2eb6a commit 7d07c37

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

lib/rules/jsx-fragments.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@ module.exports = {
4747
if (!versionUtil.testReactVersion(context, '16.2.0')) {
4848
context.report({
4949
node,
50-
message: 'Fragments are only supported starting from React v16.2'
50+
message: 'Fragments are only supported starting from React v16.2. '
51+
+ 'Please disable the `react/jsx-fragments` rule in ESLint settings or upgrade your version of React.'
5152
});
5253
return true;
5354
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@
3939
"istanbul": "^0.4.5",
4040
"mocha": "^5.2.0",
4141
"typescript": "^3.1.3",
42-
"typescript-eslint-parser": "^20.0.0"
42+
"typescript-eslint-parser": "^20.1.1"
4343
},
4444
"peerDependencies": {
4545
"eslint": "^3.0.0 || ^4.0.0 || ^5.0.0"

tests/lib/rules/jsx-fragments.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,15 @@ ruleTester.run('jsx-fragments', rule, {
8888
parser: 'babel-eslint',
8989
settings: settingsOld,
9090
errors: [{
91-
message: 'Fragments are only supported starting from React v16.2'
91+
message: 'Fragments are only supported starting from React v16.2. '
92+
+ 'Please disable the `react/jsx-fragments` rule in ESLint settings or upgrade your version of React.'
9293
}]
9394
}, {
9495
code: '<Act.Frag><Foo /></Act.Frag>',
9596
settings: settingsOld,
9697
errors: [{
97-
message: 'Fragments are only supported starting from React v16.2'
98+
message: 'Fragments are only supported starting from React v16.2. '
99+
+ 'Please disable the `react/jsx-fragments` rule in ESLint settings or upgrade your version of React.'
98100
}]
99101
}, {
100102
code: '<><Foo /></>',

0 commit comments

Comments
 (0)