Skip to content

Commit 4e059ea

Browse files
committed
Allow crossOrigin on audio elements
As audio elements also inherit from HTMLMediaElement and thus have the `crossOrigin` property
1 parent abe8381 commit 4e059ea

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/rules/no-unknown-property.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const DOM_ATTRIBUTE_NAMES = {
2626
};
2727

2828
const ATTRIBUTE_TAGS_MAP = {
29-
crossOrigin: ['script', 'img', 'video', 'link']
29+
crossOrigin: ['script', 'img', 'video', 'audio', 'link']
3030
};
3131

3232
const SVGDOM_ATTRIBUTE_NAMES = {

tests/lib/rules/no-unknown-property.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ ruleTester.run('no-unknown-property', rule, {
4242
code: '<div class="bar"></div>;',
4343
options: [{ignore: ['class']}]
4444
},
45-
{code: '<script crossOrigin />'}
45+
{code: '<script crossOrigin />'},
46+
{code: '<audio crossOrigin />'}
4647
],
4748
invalid: [{
4849
code: '<div class="bar"></div>;',
@@ -88,6 +89,6 @@ ruleTester.run('no-unknown-property', rule, {
8889
errors: [{message: 'Unknown property \'crossorigin\' found, use \'crossOrigin\' instead'}]
8990
}, {
9091
code: '<div crossOrigin />',
91-
errors: [{message: 'Invalid property \'crossOrigin\' found on tag \'div\', but it is only allowed on: script, img, video, link'}]
92+
errors: [{message: 'Invalid property \'crossOrigin\' found on tag \'div\', but it is only allowed on: script, img, video, audio, link'}]
9293
}]
9394
});

0 commit comments

Comments
 (0)